Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2468273003: Fix kernel/visitor_test (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix kernel/visitor_test - still need to change encoding of redirecting factories. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/bfa476c2b61fc56f0a4cc2bd7e74b015840d07eb

Patch Set 1 #

Patch Set 2 : Fix impact_test after changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -15 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 3 chunks +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 4 chunks +47 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/kernel/class_hierarchy_test.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 4 chunks +44 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/visitor_test.dart View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-03 15:37:56 UTC) #2
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-03 19:38:34 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-04 07:37:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bfa476c2b61fc56f0a4cc2bd7e74b015840d07eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698