Fix kernel/visitor_test

tests/compiler/dart2js/kernel/impact_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.kernel.impact_test;
 
-import 'dart:async';
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/commandline_options.dart';
 import 'package:compiler/src/common.dart';
 import 'package:compiler/src/common/names.dart';
 import 'package:compiler/src/common/resolution.dart';
 import 'package:compiler/src/compiler.dart';
+import 'package:compiler/src/constants/expressions.dart';
 import 'package:compiler/src/dart_types.dart';
 import 'package:compiler/src/elements/elements.dart';
 import 'package:compiler/src/resolution/registry.dart';
+import 'package:compiler/src/resolution/tree_elements.dart';
 import 'package:compiler/src/ssa/kernel_impact.dart';
 import 'package:compiler/src/serialization/equivalence.dart';
 import 'package:compiler/src/universe/call_structure.dart';
 import 'package:compiler/src/universe/feature.dart';
 import 'package:compiler/src/universe/use.dart';
 import 'package:expect/expect.dart';
 import '../memory_compiler.dart';
 import '../serialization/test_helper.dart';
 
 const Map<String, String> SOURCE = const <String, String>{
@@ skipping 117 matching lines @@
   testConstRedirectingFactoryInvoke();
   testConstRedirectingFactoryInvokeGeneric();
   testConstRedirectingFactoryInvokeGenericRaw();
   testConstRedirectingFactoryInvokeGenericDynamic();
   testImplicitConstructor();
   testFactoryConstructor();
   testDefaultValuesPositional();
   testDefaultValuesNamed();
   testFieldInitializer1();
   testFieldInitializer2();
+  testFieldInitializer3();
   testInstanceFieldWithInitializer();
   testInstanceFieldTyped();
   testThisInitializer();
   testSuperInitializer();
   testGenericClass();
   testSuperCall();
   testSuperGet();
   testSuperFieldSet();
   testSuperSetterSet();
   testSuperClosurization();
@@ skipping 307 matching lines @@
 class ClassFieldInitializer1 {
   var field;
   ClassFieldInitializer1(this.field);
 }
 testFieldInitializer1() => new ClassFieldInitializer1(42);
 class ClassFieldInitializer2 {
   var field;
   ClassFieldInitializer2(value) : field = value;
 }
 testFieldInitializer2() => new ClassFieldInitializer2(42);
+class ClassFieldInitializer3 {
+  var field;
+  ClassFieldInitializer3.a();
+  ClassFieldInitializer3.b(value) : field = value;
+}
+testFieldInitializer3() {
+  new ClassFieldInitializer3.a();
+  new ClassFieldInitializer3.b(42);
+}
 class ClassInstanceFieldWithInitializer {
   var field = false;
 }
 testInstanceFieldWithInitializer() => new ClassInstanceFieldWithInitializer();
 class ClassInstanceFieldTyped {
   int field;
 }
 testInstanceFieldTyped() => new ClassInstanceFieldTyped();
 class ClassGeneric<T> {
   ClassGeneric(T arg);
@@ skipping 173 matching lines @@
   for (TypeUse typeUse in impact.typeUses) {
     builder.registerTypeUse(new TypeUse.internal(
         const Unaliaser().visit(typeUse.type), typeUse.kind));
   }
   impact.constantLiterals.forEach(builder.registerConstantLiteral);
   impact.constSymbolNames.forEach(builder.registerConstSymbolName);
   impact.listLiterals.forEach(builder.registerListLiteral);
   impact.mapLiterals.forEach(builder.registerMapLiteral);
   for (Feature feature in impact.features) {
     switch (feature) {
+      case Feature.FIELD_WITHOUT_INITIALIZER:
+        if (element.isInstanceMember) {
+          bool missing = false;
+          OUTER:
+          for (ConstructorElement constructor
+              in element.enclosingClass.constructors) {
+            if (constructor.isGenerativeConstructor &&
+                !constructor.isRedirectingGenerative) {
+              for (ParameterElement parameter in constructor.parameters) {
+                if (parameter is InitializingFormalElement &&
+                    parameter.fieldElement == element) {
+                  continue OUTER;
+                }
+              }
+              if (constructor.resolvedAst.kind == ResolvedAstKind.PARSED) {
+                var function = constructor.resolvedAst.node;
+                if (function.initializers != null) {
+                  TreeElements elements = constructor.resolvedAst.elements;
+                  for (var initializer in function.initializers) {
+                    if (elements[initializer] == element) {
+                      continue OUTER;
+                    }
+                  }
+                }
+              }
+              missing = true;
+            }
+          }
+          if (!missing) continue;
+        }
+        builder.registerConstantLiteral(new NullConstantExpression());
+        break;
       case Feature.STRING_INTERPOLATION:
       case Feature.STRING_JUXTAPOSITION:
         // These are both converted into a string concatenation in kernel so
         // we cannot tell the difference.
         builder.registerFeature(Feature.STRING_INTERPOLATION);
         builder.registerFeature(Feature.STRING_JUXTAPOSITION);
         break;
       case Feature.FALL_THROUGH_ERROR:
         LibraryElement library =
             compiler.libraryLoader.lookupLibrary(Uris.dart_core);
@@ skipping 39 matching lines @@
   @override
   DartType visitFunctionType(FunctionType type, _) {
     return new FunctionType.synthesized(
         visit(type.returnType),
         visitList(type.parameterTypes),
         visitList(type.optionalParameterTypes),
         type.namedParameters,
         visitList(type.namedParameterTypes));
   }
 }