Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2468273002: [DevTools] migrate Database, IndexedDB and CacheStorage to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, blink-reviews, haraken, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] migrate Database, IndexedDB and CacheStorage to new style BUG=none R=dgozman@chromium.org TBR=michaeln@chromium.org,jsbell@chromium.org Committed: https://crrev.com/4efbc915e9ca5d803b1ba9512ceb42be0cf98184 Cr-Commit-Position: refs/heads/master@{#429389}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments & rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -158 lines) Patch
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 13 chunks +55 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 23 chunks +91 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-02 17:33:54 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2468273002/diff/1/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp File third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp (right): https://codereview.chromium.org/2468273002/diff/1/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp#newcode90 third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp:90: static const char indexedDBObjectGroup[] = "indexeddb"; Please change ...
4 years, 1 month ago (2016-11-02 17:49:37 UTC) #3
kozy
All done, thanks! https://codereview.chromium.org/2468273002/diff/1/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp File third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp (right): https://codereview.chromium.org/2468273002/diff/1/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp#newcode90 third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp:90: static const char indexedDBObjectGroup[] = "indexeddb"; ...
4 years, 1 month ago (2016-11-02 18:28:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468273002/10001
4 years, 1 month ago (2016-11-02 18:30:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 1 month ago (2016-11-02 20:40:14 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:45:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4efbc915e9ca5d803b1ba9512ceb42be0cf98184
Cr-Commit-Position: refs/heads/master@{#429389}

Powered by Google App Engine
This is Rietveld 408576698