[DevTools] migrate Database, IndexedDB and CacheStorage to new style

third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 247 matching lines @@
     return;
 
   m_resources.clear();
 }
 
 InspectorDatabaseAgent::InspectorDatabaseAgent(Page* page)
     : m_page(page), m_enabled(false) {}
 
 InspectorDatabaseAgent::~InspectorDatabaseAgent() {}
 
-void InspectorDatabaseAgent::enable(ErrorString*) {
+Response InspectorDatabaseAgent::enable() {
   if (m_enabled)
-    return;
+    return Response::OK();
   m_enabled = true;
   m_state->setBoolean(DatabaseAgentState::databaseAgentEnabled, m_enabled);
   if (DatabaseClient* client = DatabaseClient::fromPage(m_page))
     client->setInspectorAgent(this);
   DatabaseTracker::tracker().forEachOpenDatabaseInPage(
       m_page, WTF::bind(&InspectorDatabaseAgent::registerDatabaseOnCreation,
                         wrapPersistent(this)));
+  return Response::OK();
 }
 
-void InspectorDatabaseAgent::disable(ErrorString*) {
+Response InspectorDatabaseAgent::disable() {
   if (!m_enabled)
-    return;
+    return Response::OK();
   m_enabled = false;
   m_state->setBoolean(DatabaseAgentState::databaseAgentEnabled, m_enabled);
   if (DatabaseClient* client = DatabaseClient::fromPage(m_page))
     client->setInspectorAgent(nullptr);
   m_resources.clear();
+  return Response::OK();
 }
 
 void InspectorDatabaseAgent::restore() {
   if (m_state->booleanProperty(DatabaseAgentState::databaseAgentEnabled,
                                false)) {
-    ErrorString error;
-    enable(&error);
+    enable();
   }
 }
 
-void InspectorDatabaseAgent::getDatabaseTableNames(
-    ErrorString* error,
+Response InspectorDatabaseAgent::getDatabaseTableNames(
     const String& databaseId,
     std::unique_ptr<protocol::Array<String>>* names) {
-  if (!m_enabled) {
-    *error = "Database agent is not enabled";
-    return;
-  }
+  if (!m_enabled)
+    return Response::Error("Database agent is not enabled");
 
   *names = protocol::Array<String>::create();
 
   blink::Database* database = databaseForId(databaseId);
   if (database) {
     Vector<String> tableNames = database->tableNames();
     unsigned length = tableNames.size();
     for (unsigned i = 0; i < length; ++i)
       (*names)->addItem(tableNames[i]);
   }
+  return Response::OK();
 }
 
 void InspectorDatabaseAgent::executeSQL(
     const String& databaseId,
     const String& query,
     std::unique_ptr<ExecuteSQLCallback> prpRequestCallback) {
   std::unique_ptr<ExecuteSQLCallback> requestCallback =
       std::move(prpRequestCallback);
 
   if (!m_enabled) {
-    requestCallback->sendFailure("Database agent is not enabled");
+    requestCallback->sendFailure(
+        Response::Error("Database agent is not enabled"));
     return;
   }
 
   blink::Database* database = databaseForId(databaseId);
   if (!database) {
-    requestCallback->sendFailure("Database not found");
+    requestCallback->sendFailure(Response::Error("Database not found"));
     return;
   }
 
   RefPtr<ExecuteSQLCallbackWrapper> wrapper =
       ExecuteSQLCallbackWrapper::create(std::move(requestCallback));
   SQLTransactionCallback* callback =
       TransactionCallback::create(query, wrapper);
   SQLTransactionErrorCallback* errorCallback =
       TransactionErrorCallback::create(wrapper);
   VoidCallback* successCallback = TransactionSuccessCallback::create();
@@ skipping 18 matching lines @@
   return it->value->database();
 }
 
 DEFINE_TRACE(InspectorDatabaseAgent) {
   visitor->trace(m_page);
   visitor->trace(m_resources);
   InspectorBaseAgent::trace(visitor);
 }
 
 }  // namespace blink