third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp - Issue 2468233003: [DevTools] Migrate Accessibility, Log, Worker to new style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

Issue 2468233003: [DevTools] Migrate Accessibility, Log, Worker to new style (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp ('k') | third_party/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

index 45cac8342432eac1f3cbb4e879f4a188dd4e38df..579f8730534cdbb492354d5bd88757ce8a106a45 100644

--- a/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

@@ -717,7 +717,6 @@ void InspectorIndexedDBAgent::requestDatabaseNames(

std::unique_ptr<RequestDatabaseNamesCallback> requestCallback) {

LocalFrame* frame =

m_inspectedFrames->frameWithSecurityOrigin(securityOrigin);

- ErrorString errorString;

Document* document = frame ? frame->document() : nullptr;

if (!document) {

requestCallback->sendFailure(Response::Error(kNoDocumentError));

@@ -758,7 +757,6 @@ void InspectorIndexedDBAgent::requestDatabase(

std::unique_ptr<RequestDatabaseCallback> requestCallback) {

LocalFrame* frame =

m_inspectedFrames->frameWithSecurityOrigin(securityOrigin);

- ErrorString errorString;

Document* document = frame ? frame->document() : nullptr;

if (!document) {

requestCallback->sendFailure(Response::Error(kNoDocumentError));

@@ -795,7 +793,6 @@ void InspectorIndexedDBAgent::requestData(

std::unique_ptr<RequestDataCallback> requestCallback) {

LocalFrame* frame =

m_inspectedFrames->frameWithSecurityOrigin(securityOrigin);

- ErrorString errorString;

Document* document = frame ? frame->document() : nullptr;

if (!document) {

requestCallback->sendFailure(Response::Error(kNoDocumentError));

@@ -930,7 +927,6 @@ void InspectorIndexedDBAgent::clearObjectStore(

std::unique_ptr<ClearObjectStoreCallback> requestCallback) {

LocalFrame* frame =

m_inspectedFrames->frameWithSecurityOrigin(securityOrigin);

- ErrorString errorString;

Document* document = frame ? frame->document() : nullptr;

if (!document) {

requestCallback->sendFailure(Response::Error(kNoDocumentError));