Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2468173003: Fixed ugly text in the material design system menu. (Closed)

Created:
4 years, 1 month ago by bruthig
Modified:
4 years, 1 month ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed ugly text in the material design system menu. Labels have subpixel rendering enabled by default which is ugly when painted on a non-opaque canvas. Currently any system menu label in a row with a visible ink drop will be given a clear canvas at paint time because the ink drop hosting layer is promoted to paint to its layer. This is a short term fix. BUG=661714 Committed: https://crrev.com/a530e331ccd766b79d133c46cf08c1340f093e33 Cr-Commit-Position: refs/heads/master@{#429422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M ash/common/system/chromeos/settings/tray_settings.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/common/system/chromeos/tray_caps_lock.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/tray_tracing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/common/system/update/tray_update.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
bruthig
Terry, can you PTAL?
4 years, 1 month ago (2016-11-02 21:29:42 UTC) #3
tdanderson
LGTM
4 years, 1 month ago (2016-11-02 21:38:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468173003/1
4 years, 1 month ago (2016-11-02 21:40:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 22:29:29 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 22:31:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a530e331ccd766b79d133c46cf08c1340f093e33
Cr-Commit-Position: refs/heads/master@{#429422}

Powered by Google App Engine
This is Rietveld 408576698