Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: ash/common/system/tray/tray_popup_utils.cc

Issue 2468173003: Fixed ugly text in the material design system menu. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/chromeos/tray_tracing.cc ('k') | ash/common/system/update/tray_update.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/tray_popup_utils.cc
diff --git a/ash/common/system/tray/tray_popup_utils.cc b/ash/common/system/tray/tray_popup_utils.cc
index 66f938e733cfa248f79d35b6372473c86bc58e73..0ccaad381ac7fa1672e58cb5001f32bfb2c86a4d 100644
--- a/ash/common/system/tray/tray_popup_utils.cc
+++ b/ash/common/system/tray/tray_popup_utils.cc
@@ -80,6 +80,15 @@ views::Label* TrayPopupUtils::CreateDefaultLabel() {
label->SetBorder(
views::Border::CreateEmptyBorder(0, kTrayPopupLabelHorizontalPadding, 0,
kTrayPopupLabelHorizontalPadding));
+
+ // TODO(bruthig): Fix this so that |label| uses the kBackgroundColor to
+ // perform subpixel rendering instead of disabling subpixel rendering.
+ //
+ // Text rendered on a non-opaque background looks ugly and it is possible for
+ // labels to given a a clear canvas at paint time when an ink drop is visible.
+ // See http://crbug.com/661714.
+ label->SetSubpixelRenderingEnabled(false);
+
return label;
}
« no previous file with comments | « ash/common/system/chromeos/tray_tracing.cc ('k') | ash/common/system/update/tray_update.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698