Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2468143002:
Add Gamepad mapping for Samsung EI-GP20 (Closed)
|
Created:
4 years, 1 month ago by j-hyun.lee Modified:
3 years, 9 months ago CC:
lgombos, hyunjunekim2 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Gamepad mapping for Samsung EI-GP20
This adds EI-GP20 (Samsung Electronics) Gamepad mapping for Linux.
BUG=
Review-Url: https://codereview.chromium.org/2468143002
Cr-Commit-Position: refs/heads/master@{#453450}
Committed: https://chromium.googlesource.com/chromium/src/+/b559170247dff10ce8a84c6879b9abb85d712ba2
Patch Set 1 #Patch Set 2 : Add Gamepad mapping for Samsung EI-GP20 #
Total comments: 4
Patch Set 3 : Add Gamepad mapping for Samsung EI-GP20 #Patch Set 4 : Add AUTHOR #Patch Set 5 : Rebase patch #Messages
Total messages: 27 (15 generated)
Description was changed from ========== Add Gamepad mapping for Samsung EL-GP20 This adds EI-GP20 (Samsung Electronics) Gamepad mapping for Linux. BUG= ========== to ========== Add Gamepad mapping for Samsung EI-GP20 This adds EI-GP20 (Samsung Electronics) Gamepad mapping for Linux. BUG= ==========
j-hyun.lee@samsung.com changed reviewers: + b.kelemen@samsung.com, l.gombos@samsung.com
PLAT
hyunjune.kim@samsung.com changed reviewers: + bajones@chromium.org, scottmg@chromium.org
+ Add reviewers. @bajones, scottmg Hi :), Could you check this pathc? Thank you.
https://codereview.chromium.org/2468143002/diff/20001/device/gamepad/gamepad_... File device/gamepad/gamepad_standard_mappings_linux.cc (right): https://codereview.chromium.org/2468143002/diff/20001/device/gamepad/gamepad_... device/gamepad/gamepad_standard_mappings_linux.cc:298: mapped->buttons[BUTTON_INDEX_TERTIARY] = input.buttons[3]; What are buttons[2] and [5]? :) https://codereview.chromium.org/2468143002/diff/20001/device/gamepad/gamepad_... device/gamepad/gamepad_standard_mappings_linux.cc:315: mapped->buttons[BUTTON_INDEX_COUNT] = NullButton(); Don't set INDEX_COUNT, it's for a maximum value.
The CQ bit was checked by j-hyun.lee@samsung.com
The CQ bit was unchecked by j-hyun.lee@samsung.com
https://codereview.chromium.org/2468143002/diff/20001/device/gamepad/gamepad_... File device/gamepad/gamepad_standard_mappings_linux.cc (right): https://codereview.chromium.org/2468143002/diff/20001/device/gamepad/gamepad_... device/gamepad/gamepad_standard_mappings_linux.cc:298: mapped->buttons[BUTTON_INDEX_TERTIARY] = input.buttons[3]; On 2016/11/07 17:39:24, scottmg wrote: > What are buttons[2] and [5]? :) There are no H/W buttons [2] and [5] on gamepad EI_GP20. :) Those index numbers are skipped same as [8] and [9]. https://codereview.chromium.org/2468143002/diff/20001/device/gamepad/gamepad_... device/gamepad/gamepad_standard_mappings_linux.cc:315: mapped->buttons[BUTTON_INDEX_COUNT] = NullButton(); On 2016/11/07 17:39:24, scottmg wrote: > Don't set INDEX_COUNT, it's for a maximum value. Ok, I will fix it.
lgtm
@bajones Could you review this?
lgtm
The CQ bit was checked by j-hyun.lee@samsung.com
The CQ bit was unchecked by j-hyun.lee@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2468143002/#ps60001 (title: "Add AUTHOR")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by j-hyun.lee@samsung.com
The CQ bit was checked by j-hyun.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for AUTHORS: While running git apply --index -p1; error: patch failed: AUTHORS:278 error: AUTHORS: patch does not apply Patch: AUTHORS Index: AUTHORS diff --git a/AUTHORS b/AUTHORS index e22a2bd840ac926c38340b47c145f8b601c84156..9b7222e081f7f90cfe8ba9694e84f835a4eb459a 100644 --- a/AUTHORS +++ b/AUTHORS @@ -278,6 +278,7 @@ Ivan Sham <ivansham@amazon.com> J. Ryan Stinnett <jryans@chromium.org> Jacob Mandelson <jacob@mandelson.org> Jaehun Lim <ljaehun.lim@samsung.com> +Jaehyun Lee <j-hyun.lee@samsung.com> Jaekyeom Kim <btapiz@gmail.com> Jaemin Seo <jaemin86.seo@samsung.com> Jaeseok Yoon <yjaeseok@gmail.com>
The CQ bit was checked by j-hyun.lee@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from b.kelemen@samsung.com, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2468143002/#ps80001 (title: "Rebase patch")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488243440286620,
"parent_rev": "4f050b80dfb17a75c833b0e2a382bc58eecd21bd", "commit_rev":
"b559170247dff10ce8a84c6879b9abb85d712ba2"}
Message was sent while issue was closed.
Description was changed from ========== Add Gamepad mapping for Samsung EI-GP20 This adds EI-GP20 (Samsung Electronics) Gamepad mapping for Linux. BUG= ========== to ========== Add Gamepad mapping for Samsung EI-GP20 This adds EI-GP20 (Samsung Electronics) Gamepad mapping for Linux. BUG= Review-Url: https://codereview.chromium.org/2468143002 Cr-Commit-Position: refs/heads/master@{#453450} Committed: https://chromium.googlesource.com/chromium/src/+/b559170247dff10ce8a84c6879b9... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/b559170247dff10ce8a84c6879b9... |
