Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2468113004: Revert of cc: Make visible rect computation aware of pixel-moving filters (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
Reviewers:
jaydasika, ajuma, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Make visible rect computation aware of pixel-moving filters (patchset #12 id:220001 of https://codereview.chromium.org/2423483003/ ) Reason for revert: Speculative revert for webkit_tests failure on WebKit Win7 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7953 Original issue's description: > cc: Make visible rect computation aware of pixel-moving filters > > This adds a new ClipNode type (EXPANDS_CLIP) and uses such nodes to > account for the fact that certain kinds of effects have output that > depends on pixels that later get clipped out. > > BUG=653631 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/5e48a2e0284b930c68e73f44ea15807a9ffab541 > Cr-Commit-Position: refs/heads/master@{#429050} TBR=weiliangc@chromium.org,jaydasika@chromium.org,ajuma@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653631 Committed: https://crrev.com/7f3042b5845f0800784d05adf99723927bf7f966 Cr-Commit-Position: refs/heads/master@{#429227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -558 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 2 chunks +1 line, -18 lines 0 comments Download
M cc/proto/cc_conversions.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/proto/property_tree.proto View 2 chunks +1 line, -3 lines 0 comments Download
D cc/trees/clip_expander.h View 1 chunk +0 lines, -47 lines 0 comments Download
D cc/trees/clip_expander.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M cc/trees/clip_node.h View 4 chunks +1 line, -19 lines 0 comments Download
M cc/trees/clip_node.cc View 4 chunks +1 line, -72 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 10 chunks +33 lines, -128 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +0 lines, -176 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 4 chunks +10 lines, -16 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/blur-filter-page-scroll-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/css3/filters/blur-filter-page-scroll-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-expected.png View Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_chromium
Created Revert of cc: Make visible rect computation aware of pixel-moving filters
4 years, 1 month ago (2016-11-02 07:17:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468113004/1
4 years, 1 month ago (2016-11-02 07:18:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 07:19:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7f3042b5845f0800784d05adf99723927bf7f966 Cr-Commit-Position: refs/heads/master@{#429227}
4 years, 1 month ago (2016-11-02 07:21:02 UTC) #7
kjellander_chromium
4 years, 1 month ago (2016-11-02 11:45:37 UTC) #8
Message was sent while issue was closed.
On 2016/11/02 07:21:02, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7f3042b5845f0800784d05adf99723927bf7f966
> Cr-Commit-Position: refs/heads/master@{#429227}

Verifying that the revert fixed the failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

Powered by Google App Engine
This is Rietveld 408576698