Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2468093003: Makes Screen functions take a const gfx::NativeView (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sadrul, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, extensions-reviews_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, halliwell+watch_chromium.org, chromium-apps-reviews_chromium.org, scf+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, mac-reviews_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes Screen functions take a const gfx::NativeView BUG=none TEST=none R=ben@chromium.org

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M ash/display/screen_ash.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/display/screen_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/engine/app/ui/blimp_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/engine/app/ui/blimp_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/graphics/cast_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/graphics/cast_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M headless/lib/browser/headless_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/test/test_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/android/screen_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/ios/screen_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/mac/screen_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/screen_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/display/screen_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/display/test/test_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/test/test_screen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (8 generated)
sky
The CQ bit was checked by sky@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 16:04:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468093003/1
4 years, 1 month ago (2016-11-02 16:05:04 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 16:07:35 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/264759) mac_chromium_rel_ng on ...
4 years, 1 month ago (2016-11-02 16:07:36 UTC) #4
sky
The CQ bit was checked by sky@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 16:19:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468093003/20001
4 years, 1 month ago (2016-11-02 16:20:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 17:03:45 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 17:03:46 UTC) #8 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698