Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2468073002: Move LayerHitTestRects to a separate file. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu
CC:
chromium-reviews, kenneth.christiansen, tyoshino+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, loading-reviews_chromium.org, dshwang, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayerHitTestRects to a separate file. This way, ScrollingCoordinator.h doesn't need to include LayoutObject.h CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/25728d1bd2994ad9da88d3139e82917c2aa23198 Cr-Commit-Position: refs/heads/master@{#429311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +4 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/paint/LayerHitTestRects.h View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
I'm filing a few patches now, that in total will eliminate the need for LayoutObject ...
4 years, 1 month ago (2016-11-02 08:58:12 UTC) #7
Xianzhu
lgtm
4 years, 1 month ago (2016-11-02 16:11:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468073002/1
4 years, 1 month ago (2016-11-02 16:12:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 17:15:37 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 17:21:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25728d1bd2994ad9da88d3139e82917c2aa23198
Cr-Commit-Position: refs/heads/master@{#429311}

Powered by Google App Engine
This is Rietveld 408576698