Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

Issue 2467983002: Fixed composed & detail fields in PointerEvents. (Closed)
Patch Set: Added a test, fixed a old test failure. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
diff --git a/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html b/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
index 13e83b1e3926497eeb03bfa9dfaaa82025d4da11..d18ce913c8e81fb1b1c48dc2f1cc8e5dbfbd061b 100644
--- a/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
+++ b/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html
@@ -112,6 +112,9 @@ function init() {
shouldBeTrue("lastPointerEvents[0].cancelable");
}
+ shouldBeTrue("lastPointerEvents[0].composed");
+ shouldBeEqualToNumber("lastPointerEvents[0].detail", 0);
+
shouldBeEqualToNumber("lastPointerEvents[0].pointerId",
(pointerType == "mouse")? 1 : penId);
shouldBeEqualToString("lastPointerEvents[0].pointerType", pointerType);
@@ -156,11 +159,11 @@ function runMouseTests(x, y) {
eventSender.mouseMoveTo(x + 5, y + 5);
debug("");
- debug("--- click each button ---");
- for (var button = 0; button <=2; button++) {
+ debug("--- click left/right button ---");
+ // Skip middle button because it triggers autoscroll
+ for (var button = 0; button <=2; button+=2) {
bokan 2016/11/03 13:51:24 This is awkward, I'd just do: eventSender.mouseDo
mustaq 2016/11/03 14:17:17 Done.
eventSender.mouseDown(button);
eventSender.mouseUp(button);
- // TODO(crbug.com/548226): Investigate missing events in win_chromium_rel_ng on 3rd down/up.
}
debug("");

Powered by Google App Engine
This is Rietveld 408576698