third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html - Issue 2467983002: Fixed composed & detail fields in PointerEvents.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html

Issue 2467983002: Fixed composed & detail fields in PointerEvents. (Closed)

Patch Set: Added a test, fixed a old test failure. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <script src="../resources/input-modifiers.js"></script>	3 <script src="../resources/input-modifiers.js"></script>

4 <style>	4 <style>

5 div.box {	5 div.box {

6 margin: 10px;	6 margin: 10px;

7 padding: 50px;	7 padding: 50px;

8 float: left;	8 float: left;

9 }	9 }

10 </style>	10 </style>

(...skipping 94 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
105 if (!checkKeyModifiers) {	105 if (!checkKeyModifiers) {

106	106

107 if (lastPointerEvents[0].type=="pointerenter" \|\| lastPointerEvents[0]. type=="pointerleave") {	107 if (lastPointerEvents[0].type=="pointerenter" \|\| lastPointerEvents[0]. type=="pointerleave") {

108 shouldBeFalse("lastPointerEvents[0].bubbles");	108 shouldBeFalse("lastPointerEvents[0].bubbles");

109 shouldBeFalse("lastPointerEvents[0].cancelable");	109 shouldBeFalse("lastPointerEvents[0].cancelable");

110 } else {	110 } else {

111 shouldBeTrue("lastPointerEvents[0].bubbles");	111 shouldBeTrue("lastPointerEvents[0].bubbles");

112 shouldBeTrue("lastPointerEvents[0].cancelable");	112 shouldBeTrue("lastPointerEvents[0].cancelable");

113 }	113 }

114	114

	115 shouldBeTrue("lastPointerEvents[0].composed");

	116 shouldBeEqualToNumber("lastPointerEvents[0].detail", 0);

	117

115 shouldBeEqualToNumber("lastPointerEvents[0].pointerId",	118 shouldBeEqualToNumber("lastPointerEvents[0].pointerId",

116 (pointerType == "mouse")? 1 : penId);	119 (pointerType == "mouse")? 1 : penId);

117 shouldBeEqualToString("lastPointerEvents[0].pointerType", pointerType) ;	120 shouldBeEqualToString("lastPointerEvents[0].pointerType", pointerType) ;

118 shouldBeTrue("lastPointerEvents[0].isPrimary");	121 shouldBeTrue("lastPointerEvents[0].isPrimary");

119	122

120 numericAttributes.forEach(function(attribute) {	123 numericAttributes.forEach(function(attribute) {

121 var expectedValue = getExpectedNumericAttributeValueForPE(event, att ribute);	124 var expectedValue = getExpectedNumericAttributeValueForPE(event, att ribute);

122 shouldBeEqualToNumber("lastPointerEvents[0]." + attribute, expectedV alue);	125 shouldBeEqualToNumber("lastPointerEvents[0]." + attribute, expectedV alue);

123 });	126 });

124	127

(...skipping 24 matching lines...) Expand all Loading...
149	152

150 debug("--- move mouse into target ---");	153 debug("--- move mouse into target ---");

151 eventSender.mouseMoveTo(x + 5, y + 5);	154 eventSender.mouseMoveTo(x + 5, y + 5);

152 debug("");	155 debug("");

153	156

154 debug("--- move within target ---");	157 debug("--- move within target ---");

155 eventSender.mouseMoveTo(x + 7, y + 15);	158 eventSender.mouseMoveTo(x + 7, y + 15);

156 eventSender.mouseMoveTo(x + 5, y + 5);	159 eventSender.mouseMoveTo(x + 5, y + 5);

157 debug("");	160 debug("");

158	161

159 debug("--- click each button ---");	162 debug("--- click left/right button ---");

160 for (var button = 0; button <=2; button++) {	163 // Skip middle button because it triggers autoscroll

	164 for (var button = 0; button <=2; button+=2) {
	bokan 2016/11/03 13:51:24 This is awkward, I'd just do: eventSender.mouseDo This is awkward, I'd just do: eventSender.mouseDown(0) eventSender.mouseUp(0) eventSender.mouseDown(2) eventSender.mouseUp(2) mustaq 2016/11/03 14:17:17 Done. Show quoted text On 2016/11/03 13:51:24, bokan wrote: > This is awkward, I'd just do: > > eventSender.mouseDown(0) > eventSender.mouseUp(0) > eventSender.mouseDown(2) > eventSender.mouseUp(2) Done.
161 eventSender.mouseDown(button);	165 eventSender.mouseDown(button);

162 eventSender.mouseUp(button);	166 eventSender.mouseUp(button);

163 // TODO(crbug.com/548226): Investigate missing events in win_chromium_rel_ng on 3rd down/up.

164 }	167 }

165 debug("");	168 debug("");

166	169

167 debug("--- click with each modifier ---");	170 debug("--- click with each modifier ---");

168 checkKeyModifiers = true;	171 checkKeyModifiers = true;

169 forEachModifier(function(attr, modifierName, eventSenderName) {	172 forEachModifier(function(attr, modifierName, eventSenderName) {

170 eventSender.mouseDown(0, [eventSenderName]);	173 eventSender.mouseDown(0, [eventSenderName]);

171 eventSender.mouseUp(0, [eventSenderName]);	174 eventSender.mouseUp(0, [eventSenderName]);

172 });	175 });

173 checkKeyModifiers = false;	176 checkKeyModifiers = false;

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
215 runPenTests(rect.left, rect.top, 3, true);	218 runPenTests(rect.left, rect.top, 3, true);

216 }	219 }

217	220

218 init();	221 init();

219 if (window.eventSender)	222 if (window.eventSender)

220 runAllTests();	223 runAllTests();

221 else	224 else

222 debug("This test requires eventSender");	225 debug("This test requires eventSender");

223	226

224 </script>	227 </script>

OLD	NEW