Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 246783004: Revert of Recompute overflow after transform changes (Closed)

Created:
6 years, 8 months ago by aboxhall
Modified:
6 years, 8 months ago
Reviewers:
ojan, esprehn, trchen, eseidel
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Revert of Recompute overflow after transform changes (https://codereview.chromium.org/203463007/) Reason for revert: Seems very likely to have broken ChromeOS login page: https://code.google.com/p/chromium/issues/detail?id=365507 Original issue's description: > Recompute overflow after transform changes > > This CL adds a special code path that is very similar to simplifiedLayout. > When the only change on an element is the transform, we can do the minimal > work to recompute the layout overflow without much overhead from layout. > > This is done by adding an overflow recalculation phase after style changes, > if a RenderObject doesn't need layout and has moved transformed children, > the special code path will kick in. > > BUG=352460 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171923 TBR=esprehn@chromium.org,ojan@chromium.org,eseidel@chromium.org,trchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=352460 BUG=365507 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172176

Patch Set 1 #

Patch Set 2 : Local revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -265 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/compositing/overflow/transform-should-update-container-overflow.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/compositing/overflow/transform-should-update-container-overflow-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/compositing/repaint/should-not-repaint-composited-transform.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/compositing/repaint/should-not-repaint-composited-transform-expected.txt View 1 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +0 lines, -87 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 7 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 5 chunks +27 lines, -33 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aboxhall
Created Revert of Recompute overflow after transform changes
6 years, 8 months ago (2014-04-22 18:13:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/246783004/1
6 years, 8 months ago (2014-04-22 18:14:10 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 18:14:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-22 18:14:23 UTC) #4
aboxhall
The CQ bit was checked by aboxhall@chromium.org
6 years, 8 months ago (2014-04-22 21:27:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/246783004/170001
6 years, 8 months ago (2014-04-22 21:28:07 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 21:28:43 UTC) #7
Message was sent while issue was closed.
Change committed as 172176

Powered by Google App Engine
This is Rietveld 408576698