Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment.cc

Issue 2467803002: Revert of Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
index 6c5cdbd5b51040294b9c17d231aab4a1daf5d3d7..ca9dcb63a722bd2fbd1c173c590286b3d543cbe3 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
@@ -4,15 +4,14 @@
#include "core/layout/ng/ng_fragment.h"
-#include "core/layout/ng/ng_macros.h"
#include "core/layout/ng/ng_physical_fragment.h"
namespace blink {
NGMarginStrut NGFragment::MarginStrut() const {
- WRITING_MODE_IGNORED(
- "Accessing the margin strut ignoring the writing mode here is fine."
- "A margin strut is never set for a fragment");
+ // NOTE: Accessing the margin strut ignoring the writing mode here is fine.
+ // Changing the writing mode establishes a new formatting context, for which
+ // a margin strut is never set for a fragment.
return toNGPhysicalFragment(physical_fragment_)->MarginStrut();
}

Powered by Google App Engine
This is Rietveld 408576698