third_party/WebKit/Source/core/layout/ng/ng_fragment.cc - Issue 2467803002: Revert of Use NGLogicalRect instead of NGExclusion for exclusions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment.cc

Issue 2467803002: Revert of Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/layout/ng/ng_fragment.h"	5 #include "core/layout/ng/ng_fragment.h"

6	6

7 #include "core/layout/ng/ng_macros.h"

8 #include "core/layout/ng/ng_physical_fragment.h"	7 #include "core/layout/ng/ng_physical_fragment.h"

9	8

10 namespace blink {	9 namespace blink {

11	10

12 NGMarginStrut NGFragment::MarginStrut() const {	11 NGMarginStrut NGFragment::MarginStrut() const {

13 WRITING_MODE_IGNORED(	12 // NOTE: Accessing the margin strut ignoring the writing mode here is fine.

14 "Accessing the margin strut ignoring the writing mode here is fine."	13 // Changing the writing mode establishes a new formatting context, for which

15 "A margin strut is never set for a fragment");	14 // a margin strut is never set for a fragment.

16 return toNGPhysicalFragment(physical_fragment_)->MarginStrut();	15 return toNGPhysicalFragment(physical_fragment_)->MarginStrut();

17 }	16 }

18	17

19 } // namespace blink	18 } // namespace blink

OLD	NEW