Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: Source/bindings/v8/CustomElementConstructorBuilder.h

Issue 24677002: Revert "Revert "Dartium changes for custom element lifecycle events."" (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/CustomElementConstructorBuilder.h
diff --git a/Source/bindings/v8/CustomElementConstructorBuilder.h b/Source/bindings/v8/CustomElementConstructorBuilder.h
index 84e46bb568a56a6a6f8a54d0db1bdfb48638e642..f5b66c12125497f93b8281e3b6fced46a633e357 100644
--- a/Source/bindings/v8/CustomElementConstructorBuilder.h
+++ b/Source/bindings/v8/CustomElementConstructorBuilder.h
@@ -61,22 +61,23 @@ class CustomElementConstructorBuilder {
WTF_MAKE_NONCOPYABLE(CustomElementConstructorBuilder);
public:
CustomElementConstructorBuilder(ScriptState*, const Dictionary* options);
+ virtual ~CustomElementConstructorBuilder() { }
// The builder accumulates state and may run script at specific
// points. These methods must be called in order. When one fails
// (returns false), the calls must stop.
- bool isFeatureAllowed() const;
- bool validateOptions(const AtomicString& type, ExceptionState&);
- bool findTagName(const AtomicString& customElementType, QualifiedName& tagName);
- PassRefPtr<CustomElementLifecycleCallbacks> createCallbacks();
- bool createConstructor(Document*, CustomElementDefinition*, ExceptionState&);
- bool didRegisterDefinition(CustomElementDefinition*) const;
+ virtual bool isFeatureAllowed() const;
+ virtual bool validateOptions(const AtomicString& type, ExceptionState&);
+ virtual bool findTagName(const AtomicString& customElementType, QualifiedName& tagName);
+ virtual PassRefPtr<CustomElementLifecycleCallbacks> createCallbacks();
+ virtual bool createConstructor(Document*, CustomElementDefinition*, ExceptionState&);
+ virtual bool didRegisterDefinition(CustomElementDefinition*) const;
// This method collects a return value for the bindings. It is
// safe to call this method even if the builder failed; it will
// return an empty value.
- ScriptValue bindingsReturnValue() const;
+ virtual ScriptValue bindingsReturnValue() const;
private:
static WrapperTypeInfo* findWrapperType(v8::Handle<v8::Value> chain);

Powered by Google App Engine
This is Rietveld 408576698