Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2467673002: Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4* (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 93ea14f12ed4a018cc65c2f10994b2c3a7290c46..258c9431d7117eaa176d28d2a8643887e89459dd 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -51781,6 +51781,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="SafeBrowsing.GetV4HashResult"
enum="SafeBrowsingV4OperationResult">
+ <obsolete>
+ Replaced by SafeBrowsing.V4GetHash.Result.
+ </obsolete>
<owner>kcarattini@chromium.org</owner>
<summary>
Track return status from V4 GetHash attempts. The buckets of this histogram
@@ -51799,6 +51802,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="SafeBrowsing.ParseV4HashResult"
enum="SafeBrowsingParseV4HashResult">
+ <obsolete>
+ Replaced by SafeBrowsing.V4GetHash.Parse.Result.
+ </obsolete>
<owner>kcarattini@chromium.org</owner>
<summary>
Track the parsing results of a status 200 GetV4Hash request.
@@ -51807,6 +51813,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="SafeBrowsing.ParseV4UpdateResult"
enum="SafeBrowsingParseV4UpdateResult">
+ <obsolete>
+ Replaced by SafeBrowsing.V4Update.Parse.Result.
+ </obsolete>
<owner>vakh@chromium.org</owner>
<summary>
Track the parsing results of a status 200 GetV4Update request.
@@ -51989,19 +51998,69 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="SafeBrowsing.V4FullHashCacheResult"
enum="SafeBrowsingV4FullHashCacheResult">
+ <obsolete>
+ Replaced by SafeBrowsing.V4GetHash.CacheHit.Result.
+ </obsolete>
<owner>kcarattini@chromium.org</owner>
<owner>vakh@chromium.org</owner>
<summary>Track cache hits for V4 full hashes.</summary>
</histogram>
+<histogram name="SafeBrowsing.V4GetHash.CacheHit.Result"
+ enum="SafeBrowsingV4FullHashCacheResult">
+ <owner>kcarattini@chromium.org</owner>
+ <owner>vakh@chromium.org</owner>
+ <summary>Track cache hits for V4 full hashes.</summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4GetHash.Check.Result"
+ enum="SafeBrowsingV4GetHashCheckResult">
+ <owner>kcarattini@chromium.org</owner>
+ <owner>vakh@chromium.org</owner>
+ <summary>Track get hash response hits for V4 full hash requests.</summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4GetHash.Network.Time" units="ms">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ The time that it took to receive a response from the Google SafeBrowsing
+ servers for a full hash request.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4GetHash.Parse.Result"
+ enum="SafeBrowsingParseV4HashResult">
+ <owner>kcarattini@chromium.org</owner>
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track the parsing results of a status 200 GetV4Hash request.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4GetHash.Result"
+ enum="SafeBrowsingV4OperationResult">
+ <owner>kcarattini@chromium.org</owner>
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track return status from V4 GetHash attempts. The buckets of this histogram
+ overlap, so the counts cannot be used as percentages.
+ </summary>
+</histogram>
+
<histogram name="SafeBrowsing.V4GetHashCheckResult"
enum="SafeBrowsingV4GetHashCheckResult">
+ <obsolete>
+ Replaced by SafeBrowsing.V4GetHash.Check.Result.
+ </obsolete>
<owner>kcarattini@chromium.org</owner>
<owner>vakh@chromium.org</owner>
<summary>Track get hash response hits for V4 full hash requests.</summary>
</histogram>
<histogram name="SafeBrowsing.V4GetHashNetwork.Time" units="ms">
+ <obsolete>
+ Replaced by SafeBrowsing.V4GetHash.Network.Time.
+ </obsolete>
<owner>vakh@chromium.org</owner>
<summary>
The time that it took to receive a response from the Google SafeBrowsing
@@ -52286,8 +52345,44 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SafeBrowsing.V4Update.HttpResponseOrErrorCode"
+ enum="CombinedHttpResponseAndNetErrorCode">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Response or error codes when fetching updates from the SafeBrowsing PVer4
+ service.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4Update.Parse.Result"
+ enum="SafeBrowsingParseV4UpdateResult">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track the parsing results of a status 200 GetV4Update request.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4Update.ResponseSizeKB" units="KB">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ The size of the response sent by the SafeBrowsing PVer4 service, in KB.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4Update.Result"
+ enum="SafeBrowsingV4OperationResult">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track return status from V4 update attempts. The buckets of this histogram
+ overlap, so the counts cannot be used as percentages.
+ </summary>
+</histogram>
+
<histogram name="SafeBrowsing.V4UpdateHttpResponseOrErrorCode"
enum="CombinedHttpResponseAndNetErrorCode">
+ <obsolete>
+ Replaced by SafeBrowsing.V4Update.HttpResponseOrErrorCode.
+ </obsolete>
<owner>vakh@chromium.org</owner>
<summary>
Response or error codes when fetching updates from the SafeBrowsing PVer4
@@ -52296,6 +52391,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="SafeBrowsing.V4UpdateResponseSizeKB" units="KB">
+ <obsolete>
+ Replaced by SafeBrowsing.V4Update.ResponseSizeKB.
+ </obsolete>
<owner>vakh@chromium.org</owner>
<summary>
The size of the response sent by the SafeBrowsing PVer4 service, in KB.
@@ -52304,6 +52402,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="SafeBrowsing.V4UpdateResult"
enum="SafeBrowsingV4OperationResult">
+ <obsolete>
+ Replaced by SafeBrowsing.V4Update.Result.
+ </obsolete>
<owner>vakh@chromium.org</owner>
<summary>
Track return status from V4 update attempts. The buckets of this histogram

Powered by Google App Engine
This is Rietveld 408576698