Chromium Code Reviews| Index: components/safe_browsing_db/v4_update_protocol_manager.cc |
| diff --git a/components/safe_browsing_db/v4_update_protocol_manager.cc b/components/safe_browsing_db/v4_update_protocol_manager.cc |
| index ae43b2e3b404fcbc3fd97af82a2cb15a0b1f9dc6..af72201ea9a41ee25ac794ca05396849078c397c 100644 |
| --- a/components/safe_browsing_db/v4_update_protocol_manager.cc |
| +++ b/components/safe_browsing_db/v4_update_protocol_manager.cc |
| @@ -50,13 +50,13 @@ enum ParseResultType { |
| // Record parsing errors of an update result. |
| void RecordParseUpdateResult(ParseResultType result_type) { |
| - UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.ParseV4UpdateResult", result_type, |
| + UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4Update.Parse.Result", result_type, |
| PARSE_RESULT_TYPE_MAX); |
| } |
| void RecordUpdateResult(safe_browsing::V4OperationResult result) { |
| UMA_HISTOGRAM_ENUMERATION( |
| - "SafeBrowsing.V4UpdateResult", result, |
| + "SafeBrowsing.V4Update.Result", result, |
| safe_browsing::V4OperationResult::OPERATION_RESULT_MAX); |
| } |
| @@ -308,7 +308,7 @@ void V4UpdateProtocolManager::OnURLFetchComplete( |
| int response_code = source->GetResponseCode(); |
| net::URLRequestStatus status = source->GetStatus(); |
| V4ProtocolManagerUtil::RecordHttpResponseOrErrorCode( |
| - "SafeBrowsing.V4UpdateHttpResponseOrErrorCode", status, response_code); |
| + "SafeBrowsing.V4Update.HttpResponseOrErrorCode", status, response_code); |
|
Nathan Parker
2016/11/01 00:02:57
How about .Network.Result? The precise units are
Nathan Parker
2016/11/01 00:03:25
Er, I meant "The precise units are pretty clear...
vakh (use Gerrit instead)
2016/11/01 00:38:10
Done.
|
| last_response_time_ = Time::Now(); |
| @@ -325,7 +325,7 @@ void V4UpdateProtocolManager::OnURLFetchComplete( |
| } |
| request_.reset(); |
| - UMA_HISTOGRAM_COUNTS("SafeBrowsing.V4UpdateResponseSizeKB", |
| + UMA_HISTOGRAM_COUNTS("SafeBrowsing.V4Update.ResponseSizeKB", |
| data.size() / 1024); |
| // The caller should update its state now, based on parsed_server_response. |