Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager.cc

Issue 2467673002: Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4* (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_get_hash_protocol_manager.cc
diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.cc b/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
index 417e1fa887d6271e5b889e215efb87fa3bc5c8a8..1cc614916ecd82ba37667c7bb4c1bc5ad88f37ef 100644
--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
@@ -27,7 +27,7 @@ namespace {
// Record a GetHash result.
void RecordGetHashResult(safe_browsing::V4OperationResult result) {
UMA_HISTOGRAM_ENUMERATION(
- "SafeBrowsing.GetV4HashResult", result,
+ "SafeBrowsing.V4GetHash.Result", result,
safe_browsing::V4OperationResult::OPERATION_RESULT_MAX);
}
@@ -67,7 +67,7 @@ enum ParseResultType {
// Record parsing errors of a GetHash result.
void RecordParseGetHashResult(ParseResultType result_type) {
- UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.ParseV4HashResult", result_type,
+ UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4GetHash.Parse.Result", result_type,
PARSE_RESULT_TYPE_MAX);
}
@@ -90,8 +90,8 @@ enum V4FullHashCacheResultType {
// Record a full hash cache hit result.
void RecordV4FullHashCacheResult(V4FullHashCacheResultType result_type) {
- UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4FullHashCacheResult", result_type,
- FULL_HASH_CACHE_RESULT_MAX);
+ UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4GetHash.CacheHit.Result",
+ result_type, FULL_HASH_CACHE_RESULT_MAX);
}
// Enumerate GetHash hits/misses for histogramming purposes. DO NOT CHANGE THE
@@ -113,7 +113,7 @@ enum V4GetHashCheckResultType {
// Record a GetHash hit result.
void RecordV4GetHashCheckResult(V4GetHashCheckResultType result_type) {
- UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4GetHashCheckResult", result_type,
+ UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4GetHash.Check.Result", result_type,
GET_HASH_CHECK_RESULT_MAX);
}
@@ -724,7 +724,7 @@ void V4GetHashProtocolManager::OnURLFetchComplete(
}
const std::unique_ptr<FullHashCallbackInfo>& fhci = it->second;
- UMA_HISTOGRAM_LONG_TIMES("SafeBrowsing.V4GetHashNetwork.Time",
+ UMA_HISTOGRAM_LONG_TIMES("SafeBrowsing.V4GetHash.Network.Time",
clock_->Now() - fhci->network_start_time);
UpdateCache(fhci->prefixes_requested, full_hash_infos, negative_cache_expire);
MergeResults(fhci->full_hash_to_store_and_hash_prefixes, full_hash_infos,

Powered by Google App Engine
This is Rietveld 408576698