Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=651911
Committed: https://crrev.com/42c8810c0ab211a395596cd2f1b986097b0a90d7
Cr-Commit-Position: refs/heads/master@{#430118}

[vakh (use Gerrit instead), 2016-10-31 23:33:02]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-10-31 23:34:20]

Description was changed from

==========
Update the histogram names to follow the PVer4 common format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=543161
==========

to

==========
Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=651911
==========

[vakh (use Gerrit instead), 2016-10-31 23:38:50]

vakh@chromium.org changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2016-10-31 23:59:09]

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_get_hash_protocol_manager.cc (right):

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_get_hash_protocol_manager.cc:135:
"SafeBrowsing.GetV4HashHttpResponseOrErrorCode";
This one too. Maybe .V4GetHash.Network.Result, since you have a Network.Time.
"Network" here would mean "HTTP+TLS+TCP+IP"

[Nathan Parker, 2016-11-01 00:02:57]

I assume you're OK losing the continuity of data here.  Should be OK since the
v4 launch isn't underway.

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:311:
"SafeBrowsing.V4Update.HttpResponseOrErrorCode", status, response_code);
How about .Network.Result?  The precise units are pretty clean once you look at
the data.

[Nathan Parker, 2016-11-01 00:03:25]

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:311:
"SafeBrowsing.V4Update.HttpResponseOrErrorCode", status, response_code);
On 2016/11/01 00:02:57, Nathan Parker wrote:
> How about .Network.Result?  The precise units are pretty clean once you look
at
> the data.

Er, I meant "The precise units are pretty clear..."

[vakh (use Gerrit instead), 2016-11-01 00:37:19]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-11-01 00:38:10]

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_get_hash_protocol_manager.cc (right):

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_get_hash_protocol_manager.cc:135:
"SafeBrowsing.GetV4HashHttpResponseOrErrorCode";
On 2016/10/31 23:59:09, Nathan Parker wrote:
> This one too. Maybe .V4GetHash.Network.Result, since you have a Network.Time.
> "Network" here would mean "HTTP+TLS+TCP+IP"

Done.

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_update_protocol_manager.cc (right):

https://codereview.chromium.org/2467673002/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_update_protocol_manager.cc:311:
"SafeBrowsing.V4Update.HttpResponseOrErrorCode", status, response_code);
On 2016/11/01 00:03:25, Nathan Parker wrote:
> On 2016/11/01 00:02:57, Nathan Parker wrote:
> > How about .Network.Result?  The precise units are pretty clean once you look
> at
> > the data.
> 
> Er, I meant "The precise units are pretty clear..."

Done.

[vakh (use Gerrit instead), 2016-11-01 00:47:52]

vakh@chromium.org changed reviewers:
+ holte@chromium.org

[vakh (use Gerrit instead), 2016-11-01 00:47:53]

holte@ -- can you please review the changes in histograms.xml

[vakh (use Gerrit instead), 2016-11-01 00:49:51]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-11-01 00:50:09]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:50:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-11-01 00:51:06]

nparker@ review

[vakh (use Gerrit instead), 2016-11-01 00:51:08]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 00:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 02:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 02:36:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Steven Holte, 2016-11-01 20:06:37]

lgtm

[vakh (use Gerrit instead), 2016-11-02 19:57:06]

Ping.

[Nathan Parker, 2016-11-05 00:18:08]

lgtm

[vakh (use Gerrit instead), 2016-11-05 00:18:30]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2016-11-05 00:19:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 01:33:15]

Description was changed from

==========
Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=651911
==========

to

==========
Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=651911
==========

[commit-bot: I haz the power, 2016-11-05 01:33:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-05 01:34:55]

Description was changed from

==========
Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=651911
==========

to

==========
Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4*

The new names also include the module that owns them, which makes it easier to
understand the histogram.

BUG=651911

Committed: https://crrev.com/42c8810c0ab211a395596cd2f1b986097b0a90d7
Cr-Commit-Position: refs/heads/master@{#430118}
==========

[commit-bot: I haz the power, 2016-11-05 01:34:56]

Patchset 2 (id:??) landed as
https://crrev.com/42c8810c0ab211a395596cd2f1b986097b0a90d7
Cr-Commit-Position: refs/heads/master@{#430118}