Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.cc

Issue 2467673002: Update histogram names to follow the usual PVer4 format: SafeBrowsing.V4* (Closed)
Patch Set: nparker@ review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_update_protocol_manager.cc
diff --git a/components/safe_browsing_db/v4_update_protocol_manager.cc b/components/safe_browsing_db/v4_update_protocol_manager.cc
index ae43b2e3b404fcbc3fd97af82a2cb15a0b1f9dc6..867bf01c463a53a8ebc25871f8530a0673ace18e 100644
--- a/components/safe_browsing_db/v4_update_protocol_manager.cc
+++ b/components/safe_browsing_db/v4_update_protocol_manager.cc
@@ -50,13 +50,13 @@ enum ParseResultType {
// Record parsing errors of an update result.
void RecordParseUpdateResult(ParseResultType result_type) {
- UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.ParseV4UpdateResult", result_type,
+ UMA_HISTOGRAM_ENUMERATION("SafeBrowsing.V4Update.Parse.Result", result_type,
PARSE_RESULT_TYPE_MAX);
}
void RecordUpdateResult(safe_browsing::V4OperationResult result) {
UMA_HISTOGRAM_ENUMERATION(
- "SafeBrowsing.V4UpdateResult", result,
+ "SafeBrowsing.V4Update.Result", result,
safe_browsing::V4OperationResult::OPERATION_RESULT_MAX);
}
@@ -308,7 +308,7 @@ void V4UpdateProtocolManager::OnURLFetchComplete(
int response_code = source->GetResponseCode();
net::URLRequestStatus status = source->GetStatus();
V4ProtocolManagerUtil::RecordHttpResponseOrErrorCode(
- "SafeBrowsing.V4UpdateHttpResponseOrErrorCode", status, response_code);
+ "SafeBrowsing.V4Update.Network.Result", status, response_code);
last_response_time_ = Time::Now();
@@ -325,7 +325,7 @@ void V4UpdateProtocolManager::OnURLFetchComplete(
}
request_.reset();
- UMA_HISTOGRAM_COUNTS("SafeBrowsing.V4UpdateResponseSizeKB",
+ UMA_HISTOGRAM_COUNTS("SafeBrowsing.V4Update.ResponseSizeKB",
data.size() / 1024);
// The caller should update its state now, based on parsed_server_response.
« no previous file with comments | « components/safe_browsing_db/v4_get_hash_protocol_manager.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698