Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2467603002: Revert of [Telemetry] Ensure that story display names are unique (Closed)

Created:
4 years, 1 month ago by eakuefner
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Ensure that story display names are unique (patchset #1 id:1 of https://codereview.chromium.org/2465883003/ ) Reason for revert: Causing ios-simulator tests to flake??? Original issue's description: > Reland of [Telemetry] Ensure that story display names are unique (patchset #1 id:1 of https://codereview.chromium.org/2457303003/ ) > > Reason for revert: > Trying to land once again > > Original issue's description: > > Revert of [Telemetry] Ensure that story display names are unique (patchset #4 id:60001 of https://codereview.chromium.org/2153513002/ ) > > > > Reason for revert: > > Causing telemetry_perf_unittests to time out on Windows??? > > > > Original issue's description: > > > [Telemetry] Ensure that story display names are unique > > > > > > Telemetry operates on a de-facto assumption that story display names are > > > unique; this CL makes it de-jure. > > > > > > BUG=catapult:#2429 > > > > > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/42560ff37c155a0b8c319f79511154f58c465b34 > > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a3d2a9721a0bc501733c7e03722e902a7d7c0077 > > > > TBR=nednguyen@google.com > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=catapult:#2429 > > > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bed2b2a8e226c35df101015ddd37773595d07a89 > > TBR=nednguyen@google.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=catapult:#2429 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5c88b0bc325efe7ea6cf5be72fdb6009b12cb122 TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -73 lines) Patch
M telemetry/telemetry/internal/story_runner_unittest.py View 8 chunks +18 lines, -19 lines 0 comments Download
M telemetry/telemetry/page/page_run_end_to_end_unittest.py View 3 chunks +7 lines, -12 lines 0 comments Download
M telemetry/telemetry/story/story_set.py View 1 chunk +0 lines, -9 lines 0 comments Download
M telemetry/telemetry/story/story_set_unittest.py View 2 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eakuefner
Created Revert of [Telemetry] Ensure that story display names are unique
4 years, 1 month ago (2016-10-31 20:19:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467603002/1
4 years, 1 month ago (2016-10-31 20:19:59 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:20:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698