Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2457303003: Revert of [Telemetry] Ensure that story display names are unique (Closed)

Created:
4 years, 1 month ago by eakuefner
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Ensure that story display names are unique (patchset #4 id:60001 of https://codereview.chromium.org/2153513002/ ) Reason for revert: Causing telemetry_perf_unittests to time out on Windows??? Original issue's description: > [Telemetry] Ensure that story display names are unique > > Telemetry operates on a de-facto assumption that story display names are > unique; this CL makes it de-jure. > > BUG=catapult:#2429 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/42560ff37c155a0b8c319f79511154f58c465b34 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a3d2a9721a0bc501733c7e03722e902a7d7c0077 TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2429 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bed2b2a8e226c35df101015ddd37773595d07a89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -73 lines) Patch
M telemetry/telemetry/internal/story_runner_unittest.py View 8 chunks +18 lines, -19 lines 0 comments Download
M telemetry/telemetry/page/page_run_end_to_end_unittest.py View 3 chunks +7 lines, -12 lines 0 comments Download
M telemetry/telemetry/story/story_set.py View 1 chunk +0 lines, -9 lines 0 comments Download
M telemetry/telemetry/story/story_set_unittest.py View 2 chunks +2 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eakuefner
Created Revert of [Telemetry] Ensure that story display names are unique
4 years, 1 month ago (2016-10-29 04:25:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457303003/1
4 years, 1 month ago (2016-10-29 04:25:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bed2b2a8e226c35df101015ddd37773595d07a89
4 years, 1 month ago (2016-10-29 04:25:25 UTC) #5
eakuefner
4 years, 1 month ago (2016-10-31 15:23:56 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2465883003/ by eakuefner@chromium.org.

The reason for reverting is: Trying to land once again.

Powered by Google App Engine
This is Rietveld 408576698