Issue 24676002: Do not clear document background in Android WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24676002: Do not clear document background in Android WebView (Closed)

Created:
7 years, 2 months ago by boliu

Modified:
7 years ago

Reviewers:
jamesr, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Do not clear document background in Android WebView In Android WebView, if background has alpha, then the web content should blend with views underneath instead of overwriting. Add the webpreference to the blink setting and flip it in android webview. Depends on blink https://codereview.chromium.org/23483051/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240534

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
M	android_webview/native/aw_settings.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/common_param_traits_macros.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/web_preferences.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/common/webpreferences.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/common/webpreferences.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

boliu

Hi James. This is the chromium part to this blink cl: https://codereview.chromium.org/23483051/ PTAL

7 years ago (2013-12-10 18:55:25 UTC) #1

boliu

The blink CL stuck this time, and should roll into chromium today. So requesting review ...

7 years ago (2013-12-12 17:31:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/24676002/4001

7 years ago (2013-12-13 01:51:07 UTC) #5

Message was sent while issue was closed.

Change committed as 240534