Issue 2467523002: [Offline pages] Removing the offline icon from OIB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2467523002: [Offline pages] Removing the offline icon from OIB (Closed)

Created:
4 years, 1 month ago by fgorski

Modified:
4 years, 1 month ago

Reviewers:
jbudorick

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Offline pages] Removing the offline icon from OIB Simply removing the icon placeholder (the icon does not display properly right now). BUG=660426 Review-Url: https://codereview.chromium.org/2463443002 Cr-Commit-Position: refs/heads/master@{#428508} (cherry picked from commit f4e61e9950635faed2b7713efa2b7e87e3a3b387) Committed: https://chromium.googlesource.com/chromium/src/+/4ab320592ea42dd65212b94d62eca40543929a21

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -28 lines)			Patch
	M	chrome/android/java/res/layout/website_settings.xml	View		1 chunk	+8 lines, -25 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (2 generated)

fgorski

Committed patchset #1 (id:1) manually as 4ab320592ea42dd65212b94d62eca40543929a21.

4 years, 1 month ago (2016-10-31 16:41:57 UTC) #2

jbudorick

4 years, 1 month ago (2016-11-01 02:57:02 UTC) #4

Message was sent while issue was closed.

Beware that this broke lint on M55. Will follow up offline.