Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2463443002: [Offline pages] Removing the offline icon from OIB (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Removing the offline icon from OIB Simply removing the icon placeholder (the icon does not display properly right now). BUG=660426 Committed: https://crrev.com/f4e61e9950635faed2b7713efa2b7e87e3a3b387 Cr-Commit-Position: refs/heads/master@{#428508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M chrome/android/java/res/layout/website_settings.xml View 1 chunk +8 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fgorski
Dan, PTAL. In the absence of Ted, if you are not the best person to ...
4 years, 1 month ago (2016-10-28 17:57:34 UTC) #4
gone
lgtm
4 years, 1 month ago (2016-10-28 21:48:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463443002/1
4 years, 1 month ago (2016-10-28 21:50:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 22:00:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 22:03:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e61e9950635faed2b7713efa2b7e87e3a3b387
Cr-Commit-Position: refs/heads/master@{#428508}

Powered by Google App Engine
This is Rietveld 408576698