Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: src/compiler/linkage.cc

Issue 2467513002: [builtins]: Uniformly push argument count in TF-generated builtins (Closed)
Patch Set: Cleanup arm64 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/linkage.h ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/linkage.cc
diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc
index 51c54fb80643466b66ab7ba1f740b238db570475..37dbbe4303599125fa5c10e90648e01927514650 100644
--- a/src/compiler/linkage.cc
+++ b/src/compiler/linkage.cc
@@ -107,6 +107,18 @@ bool CallDescriptor::CanTailCall(const Node* node) const {
return HasSameReturnLocationsAs(CallDescriptorOf(node->op()));
}
+int CallDescriptor::CalculateFixedFrameSize() const {
+ if (IsJSFunctionCall()) {
Benedikt Meurer 2016/11/03 05:00:03 Please turn this into a switch over the call descr
danno 2016/11/03 07:55:38 Done.
+ if (PushArgumentCount()) {
+ return OptimizedBuiltinFrameConstants::kFixedSlotCount;
+ } else {
+ return StandardFrameConstants::kFixedSlotCount;
+ }
+ }
+ return IsCFunctionCall() ? (CommonFrameConstants::kFixedSlotCountAboveFp +
+ CommonFrameConstants::kCPSlotCount)
+ : TypedFrameConstants::kFixedSlotCount;
+}
CallDescriptor* Linkage::ComputeIncoming(Zone* zone, CompilationInfo* info) {
DCHECK(!info->IsStub());
« no previous file with comments | « src/compiler/linkage.h ('k') | src/compiler/mips/code-generator-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698