Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2467283005:
Add missing dependency on packed resources to ios_chrome_unittests. (Closed)
DescriptionAdd missing dependency on packed resources to ios_chrome_unittests.
The packed resources should be a dependency of //ios/chrome/app but
due to the iOS downstream addition, it currently cannot be. Add the
dependency to //ios/chrome:ios_chrome_unittests until a solution for
packed resources has been implemented.
The dependency was incorrectly removed by http://crrev.com/2443373002.
BUG=660343
Committed: https://crrev.com/b285099aa42c6be1526c77f33c93ea628fec5ab2
Cr-Commit-Position: refs/heads/master@{#429586}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. BUG=653086 ========== to ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. BUG=660343 ==========
sdefresne@chromium.org changed reviewers: + olivierrobin@chromium.org
Please take a look and send to CQ if LGTY.
The CQ bit was unchecked by sdefresne@chromium.org
LGTM. Ts this needed for other kinds of tests?
On 2016/11/03 08:37:27, Olivier Robin wrote: > LGTM. > Ts this needed for other kinds of tests? There are currently no other tests based on ios/chrome/browser.
Description was changed from ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. BUG=660343 ========== to ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. The dependency was incorrectly removed by http://crrev.com/2443373002. BUG=660343 ==========
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. The dependency was incorrectly removed by http://crrev.com/2443373002. BUG=660343 ========== to ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. The dependency was incorrectly removed by http://crrev.com/2443373002. BUG=660343 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. The dependency was incorrectly removed by http://crrev.com/2443373002. BUG=660343 ========== to ========== Add missing dependency on packed resources to ios_chrome_unittests. The packed resources should be a dependency of //ios/chrome/app but due to the iOS downstream addition, it currently cannot be. Add the dependency to //ios/chrome:ios_chrome_unittests until a solution for packed resources has been implemented. The dependency was incorrectly removed by http://crrev.com/2443373002. BUG=660343 Committed: https://crrev.com/b285099aa42c6be1526c77f33c93ea628fec5ab2 Cr-Commit-Position: refs/heads/master@{#429586} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b285099aa42c6be1526c77f33c93ea628fec5ab2 Cr-Commit-Position: refs/heads/master@{#429586} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
