Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: ios/chrome/BUILD.gn

Issue 2467283005: Add missing dependency on packed resources to ios_chrome_unittests. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/BUILD.gn
diff --git a/ios/chrome/BUILD.gn b/ios/chrome/BUILD.gn
index 9dde720bdd8f8ce6c50d8e5cf2ef7e84b2f7dfcc..e57b79046ab77d88b138eb68e45160fdc92ae334 100644
--- a/ios/chrome/BUILD.gn
+++ b/ios/chrome/BUILD.gn
@@ -10,6 +10,13 @@ test("ios_chrome_unittests") {
# Ensure that all unit tests are run.
"//ios/chrome/test:run_all_unittests",
+ # Ensure that packed resources are available (it should be a dependency
+ # of //ios/chrome/app however, Chrome on iOS uses different resources,
+ # so the dependency cannot be added there).
+ # TODO(crbug.com/653086): find a way to fix those dependency as part of
+ # building Chromium for iOS, and then remove the dependency.
+ "//ios/chrome/app/resources:packed_resources",
+
# Add unit_tests target here.
"//ios/chrome/app:unit_tests",
"//ios/chrome/app/application_delegate:unit_tests",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698