Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: components/browser_watcher/stability_report.proto

Issue 2467103002: Collect an initial set of stability activities (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/stability_report.proto
diff --git a/components/browser_watcher/stability_report.proto b/components/browser_watcher/stability_report.proto
index 0943be3db4e87a9f7e7d3a72e52a2ef34df14941..a04ada3cd24431a8e2e160e1ba61026947b6f6a4 100644
--- a/components/browser_watcher/stability_report.proto
+++ b/components/browser_watcher/stability_report.proto
@@ -49,14 +49,67 @@ message CodeModule {
optional string version = 7;
}
+// An activity represents information about something of interest on a thread.
+// Next id: 9
+message Activity {
+ enum Type {
+ NONE = 0;
+ ACT_TASK_RUN = 1;
+ ACT_LOCK_ACQUIRE = 2;
+ ACT_EVENT_WAIT = 3;
+ ACT_THREAD_JOIN = 4;
+ ACT_PROCESS_WAIT = 5;
+ }
+
+ // Identifies the type of the activity (and specifies which fields are
+ // relevant).
+ optional Type type = 1;
+
+ // Creation time of the activity.
+ optional int64 time = 2;
+
+ // The address that is the origin of the activity.
+ // Expected for ACT_TASK_*
+ optional uint64 origin_address = 3;
+
+ // The sequence identifier of the posted task.
+ // Expected for ACT_TASK_*
+ optional uint64 task_sequence_id = 4;
+
+ // The memory address of the lock object.
+ optional uint64 lock_address = 5;
+
+ // The memory address of the event object.
+ optional uint64 event_address = 6;
bcwhite 2016/11/02 16:52:37 What about the (optional) call_stack on ASAN build
manzagop (departed) 2016/11/02 20:15:23 I'm keeping it for a subsequent CL as current focu
+
+ // A unique identifier for a thread within a process.
+ optional int64 thread_id = 7;
+
+ // A unique identifier for a process.
+ optional int64 process_id = 8;
+}
+
// The state of a thread.
+// Next id: 5
message ThreadState {
+ // The name of the thread, up to a maxiumum length.
optional string thread_name = 1;
- // TODO(manzagop): flesh out.
+
+ // The identifier of the thread.
+ optional int64 thread_id = 2;
+
+ // The activity stack. |activity_cnt| specifies the number of activities on
+ // stack and |activities| holds the base of the stack (up to a maximum size).
+ optional int32 activity_cnt = 3;
bcwhite 2016/11/02 16:52:37 Is it typical to use abbreviated "cnt" for a count
manzagop (departed) 2016/11/02 20:15:23 A rapid chromium code search seems to say no. Done
+ repeated Activity activities = 4;
}
// The state of a process.
+// Next id: 4
message ProcessState {
+ // The identifier of the process.
+ optional int64 process_id = 3;
+
// Note: likely only a subset of modules of interest (e.g. Chromium's own
// modules).
repeated CodeModule modules = 1;

Powered by Google App Engine
This is Rietveld 408576698