Collect an initial set of stability activities

components/browser_watcher/stability_report.proto

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package browser_watcher;
 
@@ skipping 31 matching lines @@
   // specific version and build of the associated debug file.  This may be
   // the same as code_identifier when the debug_file and code_file are
   // identical or when the same identifier is used to identify distinct
   // debug and code files.
   optional string debug_identifier = 6;
 
   // A human-readable representation of the code module's version.
   optional string version = 7;
 }
 
+// An activity represents information about something of interest on a thread.
+// Next id: 9
+message Activity {
+  enum Type {
+    NONE = 0;
+    ACT_TASK_RUN = 1;
+    ACT_LOCK_ACQUIRE = 2;
+    ACT_EVENT_WAIT = 3;
+    ACT_THREAD_JOIN = 4;
+    ACT_PROCESS_WAIT = 5;
+  }
+
+  // Identifies the type of the activity (and specifies which fields are
+  // relevant).
+  optional Type type = 1;
+
+  // Creation time of the activity.
+  optional int64 time = 2;
+
+  // The address that is the origin of the activity.
+  // Expected for ACT_TASK_*
+  optional uint64 origin_address = 3;
+
+  // The sequence identifier of the posted task.
+  // Expected for ACT_TASK_*
+  optional uint64 task_sequence_id = 4;
+
+  // The memory address of the lock object.
+  optional uint64 lock_address = 5;
+
+  // The memory address of the event object.
+  optional uint64 event_address = 6;

[bcwhite, 2016/11/02 16:52:37]

What about the (optional) call_stack on ASAN builds?

[manzagop (departed), 2016/11/02 20:15:23]

I'm keeping it for a subsequent CL as current focus is on the postmortem
reports.

+
+  // A unique identifier for a thread within a process.
+  optional int64 thread_id = 7;
+
+  // A unique identifier for a process.
+  optional int64 process_id = 8;
+}
+
 // The state of a thread.
+// Next id: 5
 message ThreadState {
+  // The name of the thread, up to a maxiumum length.
   optional string thread_name = 1;
-  // TODO(manzagop): flesh out.
+
+  // The identifier of the thread.
+  optional int64 thread_id = 2;
+
+  // The activity stack. |activity_cnt| specifies the number of activities on
+  // stack and |activities| holds the base of the stack (up to a maximum size).
+  optional int32 activity_cnt = 3;

[bcwhite, 2016/11/02 16:52:37]

Is it typical to use abbreviated "cnt" for a count?

[manzagop (departed), 2016/11/02 20:15:23]

A rapid chromium code search seems to say no. Done.

+  repeated Activity activities = 4;
 }
 
 // The state of a process.
+// Next id: 4
 message ProcessState {
+  // The identifier of the process.
+  optional int64 process_id = 3;
+
   // Note: likely only a subset of modules of interest (e.g. Chromium's own
   // modules).
   repeated CodeModule modules = 1;
   repeated ThreadState threads = 2;
   // TODO(manzagop): add experiment state.
 }
 
 // A stability report contains information pertaining to the execution of a
 // single logical instance of a "chrome browser". It is comprised of information
 // about the system state and about the chrome browser's processes.
 message StabilityReport {
   optional SystemState system_state = 1;
   // TODO(manzagop): revisit whether a single repeated field should contain all
   //     processes, or whether it's preferable to have separate fields per type.
   // TODO(manzagop): add information about the type of process, pid, process
   //     times (e.g. start time), hierarchical relationships (e.g. parent pid),
   //     command line, etc.
   repeated ProcessState process_states = 2;
 }