Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2467073002: Revert "Create internal fields on global proxy objects" (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Create internal fields on global proxy objects" This reverts commit 26547761efbcb6ed0d07f894afe3cbf2b5dd0068. Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui... See also: https://github.com/v8/v8/wiki/Blink-layout-tests BUG=v8:5588 TBR=jochen@chromium.org, verwaest@chromium.org, hablich@chromium.org Committed: https://crrev.com/b19abf53718ce6f1145ce4ced5bc3ef7f59949f2 Cr-Commit-Position: refs/heads/master@{#40686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M include/v8.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/api-natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467073002/1
4 years, 1 month ago (2016-11-01 20:06:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 20:39:44 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b19abf53718ce6f1145ce4ced5bc3ef7f59949f2
Cr-Commit-Position: refs/heads/master@{#40686}

Powered by Google App Engine
This is Rietveld 408576698