src/api-natives.cc - Issue 2467073002: Revert "Create internal fields on global proxy objects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api-natives.cc

Issue 2467073002: Revert "Create internal fields on global proxy objects" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api-natives.cc

diff --git a/src/api-natives.cc b/src/api-natives.cc

index 72594fca5f0cd748e0a8d16f0ffd0a9fb2ba4ae2..a620b210a4b65156560b3788d3fa3ce8322d3ccb 100644

--- a/src/api-natives.cc

+++ b/src/api-natives.cc

@@ -643,7 +643,6 @@ Handle<JSFunction> ApiNatives::CreateApiFunction(

case GlobalProxyType:

type = JS_GLOBAL_PROXY_TYPE;

instance_size += JSGlobalProxy::kSize;

- DCHECK_EQ(instance_size, JSGlobalProxy::kSizeWithInternalFields);

break;

default:

UNREACHABLE();

« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »