Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2467063002: Move FF and Canary to green on travis (Closed)

Created:
4 years, 1 month ago by vsm
Modified:
4 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M .travis.yml View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/karma.conf.js View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/package.json View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test-main.js View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 12 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
vsm
4 years, 1 month ago (2016-11-01 20:00:37 UTC) #3
vsm
4 years, 1 month ago (2016-11-02 18:10:37 UTC) #5
Bob Nystrom
Couple nits then LGTM! https://codereview.chromium.org/2467063002/diff/1/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2467063002/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode33 pkg/dev_compiler/test/browser/language_tests.js:33: console.log(firefox_fail); Remove the log(). https://codereview.chromium.org/2467063002/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode388 ...
4 years, 1 month ago (2016-11-02 21:37:21 UTC) #6
vsm
4 years, 1 month ago (2016-11-03 14:44:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4874480d55a9abb05dcf92b1f3b3e398599538d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698