pkg/dev_compiler/test/browser/language_tests.js - Issue 2467063002: Move FF and Canary to green on travis

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2467063002: Move FF and Canary to green on travis (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: pkg/dev_compiler/test/browser/language_tests.js

diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js

index 23789a67457d754f706e871dac1b2f4d0171b7db..378ac92a5074f916e949fdd377b98bd450667e84 100644

--- a/pkg/dev_compiler/test/browser/language_tests.js

+++ b/pkg/dev_compiler/test/browser/language_tests.js

@@ -2,8 +2,8 @@

// BSD-style license that can be found in the LICENSE file.

-define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

- function(dart_sdk, async_helper, expect, unittest, require) {

+define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],

+ function(dart_sdk, async_helper, expect, unittest, is, require) {

'use strict';

async_helper = async_helper.async_helper;

@@ -14,6 +14,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

// Test attributes are a list of strings, or a string for a single

// attribute. Valid attributes are:

+ // 'pass' - test passes (default)

// 'skip' - don't run the test

// 'fail' - test fails

// 'timeout' - test times out

@@ -22,10 +23,15 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

// 'unittest' - run separately as a unittest test.

// Common combinations:

+ const pass = 'pass';

const fail = 'fail';

const skip_fail = ['skip', 'fail'];

const skip_timeout = ['skip', 'timeout'];

+ // Browsers

+ const firefox_fail = is.firefox() ? fail : pass;

+ const chrome_fail = is.chrome() ? fail : pass;

// Tests marked with this are still using the deprecated unittest package

// because they rely on its support for futures and asynchronous tests, which

// expect and minitest do not handle.

@@ -257,6 +263,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'mixin_type_parameter3_test': skip_fail,

'modulo_test': fail,

'named_parameter_clash_test': skip_fail,

+ 'named_parameters_passing_falsy_test': firefox_fail,

'nan_identical_test': skip_fail,

'nested_switch_label_test': skip_fail,

'number_identifier_test_05_multi': skip_fail,

@@ -290,6 +297,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'throwing_lazy_variable_test': skip_fail,

'top_level_non_prefixed_library_test': skip_fail,

'truncdiv_test': fail, // did not throw

+ 'type_literal_test': firefox_fail,

'type_variable_nested_test': skip_fail, // unsound is-check

'type_variable_typedef_test': skip_fail, // unsound is-check

@@ -343,8 +351,10 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'const_list_remove_range_test': fail,

'const_list_set_range_test': fail,

'double_parse_test_01_multi': fail,

+ 'double_parse_test_02_multi': firefox_fail,

'error_stack_trace1_test': fail,

'error_stack_trace2_test': fail,

+ 'for_in_test': firefox_fail,

'hash_map2_test': skip_timeout,

'hash_set_test_01_multi': fail,

'hidden_library2_test_01_multi': fail,

@@ -367,22 +377,28 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'main_test': fail,

'map_keys2_test': fail,

'map_to_string_test': fail,

+ 'map_from_iterable_test': firefox_fail,

'nan_infinity_test_01_multi': fail,

'null_nosuchmethod_test': fail,

'null_test': fail,

'num_sign_test': fail,

'regress_r21715_test': fail,

'throw_half_surrogate_pair_test_02_multi': fail,

- 'stacktrace_current_test': fail,

+ 'splay_tree_from_iterable_test': firefox_fail,

+ 'stacktrace_current_test': chrome_fail,

+ 'string_case_test_01_multi': firefox_fail,

'string_fromcharcodes_test': skip_timeout,

'string_operations_with_null_test': fail,

'symbol_reserved_word_test_06_multi': fail,

'symbol_reserved_word_test_09_multi': fail,

'symbol_reserved_word_test_12_multi': fail,

'throw_half_surrogate_pair_test_01_multi': fail,

+ 'unicode_test': firefox_fail,

+ 'uri_parameters_all_test': firefox_fail,

// TODO(rnystrom): Times out because it tests a huge number of

// combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).

'uri_parse_test': skip_timeout,

+ 'uri_test': firefox_fail,

'list_insert_test': fail,

'list_removeat_test': fail,

@@ -390,7 +406,9 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'corelib/regexp': {

- 'default_arguments_test': fail

+ 'default_arguments_test': fail,

+ 'UC16_test': firefox_fail,

+ 'unicodeCaseInsensitive_test': firefox_fail

'lib/convert': {

@@ -414,7 +432,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'lib/html': {

'async_spawnuri_test': async_unittest,

'async_test': async_unittest,

- 'audiocontext_test': 'fail', // was sdk#27578, needs triage

+ 'audiocontext_test': is.chrome('<=55') ? fail : pass, // was sdk#27578, needs triage

'blob_constructor_test': 'fail', // was sdk#27578, needs triage

'canvas_test': ['unittest'],

'canvasrenderingcontext2d_test': ['unittest'],

@@ -437,6 +455,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

// Failure: 'Expected 56 to be in the inclusive range [111, 160].'.

'element_offset_test': 'fail',

'element_test': async_unittest,

+ 'element_types_test': firefox_fail,

'event_customevent_test': async_unittest,

'events_test': async_unittest,

@@ -484,12 +503,14 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'postmessage_structured_test': async_unittest,

'request_animation_frame_test': async_unittest,

'resource_http_test': async_unittest,

- 'rtc_test': 'fail', // was sdk#27578, needs triage

+ 'rtc_test': is.chrome('<=55') ? fail : pass, // was sdk#27578, needs triage

// Expected 1, got null.

'serialized_script_value_test': 'fail',

+ 'shadow_dom_test': firefox_fail,

'speechrecognition_test': 'fail', // was sdk#27578, needs triage

- 'svgelement_test': 'fail', // was sdk#27578, needs triage

+ 'svgelement_test': chrome_fail, // was sdk#27578, needs triage

+ 'text_event_test': firefox_fail,

'touchevent_test': 'fail', // was sdk#27578, needs triage

'transferables_test': async_unittest,

'transition_event_test': async_unittest,

@@ -665,6 +686,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'require'],

'typedef_metadata_test': fail,

'typedef_test': fail,

'typevariable_mirror_metadata_test': fail,

+ 'unmangled_type_test': firefox_fail,

'unnamed_library_test': fail,

'variable_is_const_test_none_multi': fail,

« no previous file with comments | « pkg/dev_compiler/test-main.js ('k') | no next file » | no next file with comments »