Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2467013002: Disallow [ Missing ] expectations in test expectations files. (Closed)
Patch Set: Change current missing expectations to skips Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index af8d62ca6ec4a2f45b077d03d1885a4844e32610..52c21aed3abf994fbd6d3f695bf2a1889b7fc358 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -928,7 +928,7 @@ class Port(object):
"""
fs = self.host.filesystem
if self.default_smoke_test_only():
- smoke_test_filename = fs.join(self.layout_tests_dir(), 'SmokeTests')
+ smoke_test_filename = self.path_to_smoke_tests_file()
if fs.exists(smoke_test_filename) and test not in fs.read_text_file(smoke_test_filename):
return True
@@ -941,6 +941,9 @@ class Port(object):
return (SKIP in full_expectations.get_expectations(test) and
SKIP not in generic_expectations.get_expectations(test))
+ def path_to_smoke_tests_file(self):
+ return self.host.filesystem.join(self.layout_tests_dir(), 'SmokeTests')
+
def _tests_from_skipped_file_contents(self, skipped_file_contents):
tests_to_skip = []
for line in skipped_file_contents.split('\n'):

Powered by Google App Engine
This is Rietveld 408576698