Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2466953003: git-cl-land: print url of final commit location (Closed)

Created:
4 years, 1 month ago by agable
Modified:
4 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix the call and the tests #

Patch Set 3 : Fix typo #

Patch Set 4 : Avoid iterating over nonetype #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M gerrit_util.py View 1 chunk +6 lines, -0 lines 0 comments Download
M git_cl.py View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
agable
PTAL
4 years, 1 month ago (2016-11-01 18:22:58 UTC) #2
tandrii(chromium)
lgtm
4 years, 1 month ago (2016-11-01 18:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466953003/60001
4 years, 1 month ago (2016-11-01 19:52:07 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 19:55:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/32978d969ce27f...

Powered by Google App Engine
This is Rietveld 408576698