Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tests/git_cl_test.py

Issue 2466953003: git-cl-land: print url of final commit location (Closed)
Patch Set: Avoid iterating over nonetype Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 4b4e295e2a77de06f991092b7a5c5d2e264d53c1..6d94ff7a0ed2e2a1326eddce2b7e0dd157ee3e18 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -2122,11 +2122,17 @@ class TestGitCl(TestCase):
'labels': {},
'current_revision': 'deadbeaf',
}
+ cl._codereview_impl._GetChangeCommit = lambda: {
+ 'commit': 'deadbeef',
+ 'web_links': [{'name': 'gerrit',
+ 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
+ }
cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
out = StringIO.StringIO()
self.mock(sys, 'stdout', out)
self.assertEqual(0, cl.CMDLand(force=True, bypass_hooks=True, verbose=True))
self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
+ self.assertRegexpMatches(out.getvalue(), 'Landed as .*deadbeef')
BUILDBUCKET_BUILDS_MAP = {
'9000': {
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698