Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2466863003: Finalize backend for fetching more NTPSnippets. (Closed)
Patch Set: Known suggestion are now a parameter for Fetch. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
index b00c2c40ec6a97ec934b12fac8e58545da766b65..84134f894e87932053cad1dfe9cba50826b9a230 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
@@ -91,10 +91,11 @@ void PhysicalWebPageSuggestionsProvider::FetchSuggestionImage(
FROM_HERE, base::Bind(callback, gfx::Image()));
}
-void PhysicalWebPageSuggestionsProvider::FetchMore(
+void PhysicalWebPageSuggestionsProvider::Fetch(
const Category& category,
- FetchedMoreCallback callback) {
- // Ignored.
+ std::set<std::string> known_suggestion_ids,
+ FetchingCallback callback) {
+ NOTREACHED();
}
void PhysicalWebPageSuggestionsProvider::ClearHistory(

Powered by Google App Engine
This is Rietveld 408576698