components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h - Issue 2466863003: Finalize backend for fetching more NTPSnippets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2466863003: Finalize backend for fetching more NTPSnippets. (Closed)

Patch Set: Known suggestion are now a parameter for Fetch. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h ('K') | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | components/ntp_snippets/remote/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

index 1147e09b7f9bb06e9f06ec0385aa57ad5ea97924..cd789d37077387631085547c1bb5fdb6ac3f5bc3 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

@@ -48,8 +48,9 @@ class PhysicalWebPageSuggestionsProvider : public ContentSuggestionsProvider {

void DismissSuggestion(const ContentSuggestion::ID& suggestion_id) override;

void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id,

const ImageFetchedCallback& callback) override;

- void FetchMore(const Category& category,

- FetchedMoreCallback callback) override;

+ void Fetch(const Category& category,

+ std::set<std::string> known_suggestion_ids,

+ FetchingCallback callback) override;

void ClearHistory(

base::Time begin,

base::Time end,