Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2466823002: Remove recipe for ozone_ecs (Closed)

Created:
4 years, 1 month ago by tikuta
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove recipe for ozone_ecs ozone_ecs buildbots were removed. https://codereview.chromium.org/1920133002 * remove an arg used only in ozone_ecs recipe from chromium.runtest BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/6739408c1342b8ed2f229325a80aafe6403b9fd1

Patch Set 1 #

Patch Set 2 : remove ozone_ecs #

Total comments: 2

Patch Set 3 : remove --no-spawn-dbus from runtest.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2509 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M scripts/slave/recipes/ozone_ecs.py View 1 1 chunk +0 lines, -133 lines 0 comments Download
M scripts/slave/recipes/ozone_ecs.expected/basic.json View 1 1 chunk +0 lines, -784 lines 0 comments Download
M scripts/slave/recipes/ozone_ecs.expected/check_ecs_deps_fail.json View 1 1 chunk +0 lines, -788 lines 0 comments Download
M scripts/slave/recipes/ozone_ecs.expected/trybot.json View 1 1 chunk +0 lines, -794 lines 0 comments Download
M scripts/slave/runtest.py View 1 2 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
tikuta
4 years, 1 month ago (2016-11-01 05:09:55 UTC) #9
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-01 16:45:29 UTC) #12
Paweł Hajdan Jr.
https://codereview.chromium.org/2466823002/diff/20001/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (left): https://codereview.chromium.org/2466823002/diff/20001/scripts/slave/recipe_modules/chromium/api.py#oldcode429 scripts/slave/recipe_modules/chromium/api.py:429: full_args.append('--no-spawn-dbus') Can we also remove this flag from runtest.py? ...
4 years, 1 month ago (2016-11-02 10:06:40 UTC) #13
tikuta
https://codereview.chromium.org/2466823002/diff/20001/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (left): https://codereview.chromium.org/2466823002/diff/20001/scripts/slave/recipe_modules/chromium/api.py#oldcode429 scripts/slave/recipe_modules/chromium/api.py:429: full_args.append('--no-spawn-dbus') On 2016/11/02 10:06:40, Paweł Hajdan Jr. wrote: > ...
4 years, 1 month ago (2016-11-04 02:51:00 UTC) #16
Paweł Hajdan Jr.
LGTM Yes, please also remove the flag from chromium/src copy.
4 years, 1 month ago (2016-11-04 07:16:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466823002/40001
4 years, 1 month ago (2016-11-04 07:42:06 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 07:52:04 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/6739408c1342b8ed2f22...

Powered by Google App Engine
This is Rietveld 408576698