Remove recipe for ozone_ecs

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
@@ skipping 337 matching lines @@
           raise self.m.step.InfraFailure('Infra compile failure: %s' % e)
 
       raise e
 
   @recipe_util.returns_placeholder
   def test_launcher_filter(self, tests):
     return TestLauncherFilterFileInputPlaceholder(self, tests)
 
   def runtest(self, test, args=None, xvfb=False, name=None, annotate=None,
               results_url=None, perf_dashboard_id=None, test_type=None,
-              python_mode=False, spawn_dbus=True, parallel=False,
+              python_mode=False, parallel=False,
               point_id=None, revision=None, webkit_revision=None,
               test_launcher_summary_output=None, flakiness_dash=None,
               perf_id=None, perf_config=None, chartjson_file=False,
               disable_src_side_runtest_py=False, **kwargs):
     """Return a runtest.py invocation."""
     args = args or []
     assert isinstance(args, list)
 
     t_name, ext = self.m.path.splitext(self.m.path.basename(test))
     if not python_mode and self.m.platform.is_win and ext == '':
@@ skipping 49 matching lines @@
     # These properties are specified on every bot, so pass them down
     # unconditionally.
     full_args.append('--builder-name=%s' % self.m.properties['buildername'])
     full_args.append('--slave-name=%s' % self.m.properties['slavename'])
     # A couple of the recipes contain tests which don't specify a buildnumber,
     # so make this optional.
     if self.m.properties.get('buildnumber') is not None:
       full_args.append('--build-number=%s' % self.m.properties['buildnumber'])
     if ext == '.py' or python_mode:
       full_args.append('--run-python-script')
-    if not spawn_dbus:
-      full_args.append('--no-spawn-dbus')

[Paweł Hajdan Jr., 2016/11/02 10:06:40]

Can we also remove this flag from runtest.py?

Consider verifying that nothing internal depends on that. Quick check on
cs.chromium.org shows ecs was the only thing in public repos.

[tikuta, 2016/11/04 02:51:00]

Done.

I ran `fgrep 'no-spawn-dbus' . -rsnI` in build_internal and confirmed that only
ozone_ecs recipes use this option.

Do I need to take care below?
https://cs.chromium.org/chromium/src/infra/scripts/legacy/scripts/slave/runte...

     if point_id:
       full_args.append('--point-id=%d' % point_id)
     if revision:
       full_args.append('--revision=%s' % revision)
     if webkit_revision:
       # TODO(kbr): figure out how to cover this line of code with
       # tests after the removal of the GPU recipe. crbug.com/584469
       full_args.append(
           '--webkit-revision=%s' % webkit_revision)  # pragma: no cover
 
@@ skipping 464 matching lines @@
       }))
 
   def get_annotate_by_test_name(self, test_name):
     return 'graphing'
 
   def download_lto_plugin(self):
     return self.m.python(
         name='download LTO plugin',
         script=self.m.path['checkout'].join(
             'build', 'download_gold_plugin.py'))