Issue 2466683002: Delete download in Android DownloadManager when download is deleted from download home

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2466683002: Delete download in Android DownloadManager when download is deleted from download home (Closed)

Created:
4 years, 1 month ago by qinmin

Modified:
4 years, 1 month ago

Reviewers:
gone

CC:
chromium-reviews, asanka, agrieve+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Delete download in Android DownloadManager when download is deleted from download home This change adds a SharedPreference file to map download GUIDs to android download Ids. When a download is removed from download home, also remove it from Android DM. TBR=dfalcantara@chromium.org BUG=658829 Review-Url: https://codereview.chromium.org/2456593002 Cr-Commit-Position: refs/heads/master@{#428495} (cherry picked from commit b318140c9474e8e133bf3a403e94e7569c9bd4cd) Committed: https://chromium.googlesource.com/chromium/src/+/bcba1820e2fd8a7e26dc36104350177623415610

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -7 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java	View		5 chunks	+64 lines, -5 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

qinmin

4 years, 1 month ago (2016-10-31 19:51:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bcba1820e2fd8a7e26dc36104350177623415610 (presubmit successful).