Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2456593002: Delete download in Android DownloadManager when download is deleted from download home (Closed)

Created:
4 years, 1 month ago by qinmin
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete download in Android DownloadManager when download is deleted from download home This change adds a SharedPreference file to map download GUIDs to android download Ids. When a download is removed from download home, also remove it from Android DM. BUG=658829 Committed: https://crrev.com/b318140c9474e8e133bf3a403e94e7569c9bd4cd Cr-Commit-Position: refs/heads/master@{#428495}

Patch Set 1 #

Patch Set 2 : lazily initialize db #

Patch Set 3 : using SharedPrefs instead of sqlite db #

Total comments: 6

Patch Set 4 : use SharedPreference as hashmap directly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 1 2 3 5 chunks +64 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
qinmin
PTAL
4 years, 1 month ago (2016-10-26 21:39:57 UTC) #2
gone
I'm not terribly familiar with how SQL databases work :/ Does it make sense to ...
4 years, 1 month ago (2016-10-26 21:49:58 UTC) #3
qinmin
ianwen@, are you ok with this sqldatabase code review?
4 years, 1 month ago (2016-10-26 22:01:12 UTC) #5
qinmin
Dan, PTAL again, switched to use SharedPreference instead of database
4 years, 1 month ago (2016-10-28 18:25:17 UTC) #7
gone
https://codereview.chromium.org/2456593002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java (right): https://codereview.chromium.org/2456593002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java#newcode69 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java:69: return downloadId + "," + downloadGuid; Worth using a ...
4 years, 1 month ago (2016-10-28 18:51:03 UTC) #9
qinmin
https://codereview.chromium.org/2456593002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java (right): https://codereview.chromium.org/2456593002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java#newcode69 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java:69: return downloadId + "," + downloadGuid; On 2016/10/28 18:51:02, ...
4 years, 1 month ago (2016-10-28 19:21:43 UTC) #10
gone
lgtm
4 years, 1 month ago (2016-10-28 19:55:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456593002/80001
4 years, 1 month ago (2016-10-28 20:48:25 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 1 month ago (2016-10-28 21:19:21 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 21:23:29 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b318140c9474e8e133bf3a403e94e7569c9bd4cd
Cr-Commit-Position: refs/heads/master@{#428495}

Powered by Google App Engine
This is Rietveld 408576698