Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2466473003: [Devtools] Fixed contextmenu in network timeline experiment. (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed contextmenu in network timeline experiment. This patch fixes a minor regression where if you summoned a context menu from the timeline you would not get anything. R=dgozman BUG=653738 Committed: https://crrev.com/d70482b0d98af3a78fba0425bf0ea18cad869548 Cr-Commit-Position: refs/heads/master@{#428852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
allada
PTL
4 years, 1 month ago (2016-10-31 19:02:01 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-10-31 19:49:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466473003/1
4 years, 1 month ago (2016-10-31 22:43:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 22:48:51 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 22:50:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d70482b0d98af3a78fba0425bf0ea18cad869548
Cr-Commit-Position: refs/heads/master@{#428852}

Powered by Google App Engine
This is Rietveld 408576698