Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2466473003: [Devtools] Fixed contextmenu in network timeline experiment. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index d29d4c6317fade0ef6ce7d885759d6ac3bc2a208..c1c765a7e5eabef124cc9c8dbb0331f10a7ebdd2 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -335,7 +335,7 @@ WebInspector.NetworkLogView.prototype = {
_setupDataGrid: function()
{
this._dataGrid = this._columns.dataGrid();
- this._dataGrid.setRowContextMenuCallback(this._onRowContextMenu.bind(this));
+ this._dataGrid.setRowContextMenuCallback((contextMenu, node) => this.handleContextMenuForRequest(contextMenu, node.request()));
this._dataGrid.setStickToBottom(true);
this._dataGrid.setName("networkLog");
this._dataGrid.setResizeMethod(WebInspector.DataGrid.ResizeMethod.Last);
@@ -880,12 +880,10 @@ WebInspector.NetworkLogView.prototype = {
/**
* @param {!WebInspector.ContextMenu} contextMenu
- * @param {!WebInspector.DataGridNode} node
+ * @param {!WebInspector.NetworkRequest} request
*/
- _onRowContextMenu: function(contextMenu, node)
+ handleContextMenuForRequest: function(contextMenu, request)
{
- var request = node.request();
-
contextMenu.appendApplicableItems(request);
var copyMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Copy"));
if (request) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698