Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2466463004:
Reenable CPU tracing agent for BattOr benchmarks (Closed)
|
Created:
4 years, 1 month ago by charliea (OOO until 10-5) Modified:
4 years, 1 month ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReenable CPU tracing agent for BattOr benchmarks
After disabling the agent, we made it a no-op on Windows where it was
causing hangs.
BUG=647443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/78c72585a8762486252b7d10ce9036a6ddf8d0f7
Cr-Commit-Position: refs/heads/master@{#429332}
Patch Set 1 #
Messages
Total messages: 23 (16 generated)
Description was changed from ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 ========== to ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
charliea@chromium.org changed reviewers: + nednguyen@google.com
Description was changed from ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. DO NOT SUBMIT until after https://codereview.chromium.org/2453683004/ is rolled into Chromium. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. DO NOT SUBMIT until after https://codereview.chromium.org/2453683004/ is rolled into Chromium. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. DO NOT SUBMIT until after https://codereview.chromium.org/2453683004/ is rolled into Chromium. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by nednguyen@google.com
lgtm
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. DO NOT SUBMIT until after https://codereview.chromium.org/2453683004/ is rolled into Chromium. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reenable CPU tracing agent for BattOr benchmarks After disabling the agent, we made it a no-op on Windows where it was causing hangs. BUG=647443 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/78c72585a8762486252b7d10ce9036a6ddf8d0f7 Cr-Commit-Position: refs/heads/master@{#429332} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/78c72585a8762486252b7d10ce9036a6ddf8d0f7 Cr-Commit-Position: refs/heads/master@{#429332} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
