Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/perf/benchmarks/battor.py

Issue 2466463004: Reenable CPU tracing agent for BattOr benchmarks (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/battor.py
diff --git a/tools/perf/benchmarks/battor.py b/tools/perf/benchmarks/battor.py
index aeb863c83d6344f5636e604d32d5ed0319b2d1c5..39586d7c9e9d8c1076bac0f038c6d7000ec5998d 100644
--- a/tools/perf/benchmarks/battor.py
+++ b/tools/perf/benchmarks/battor.py
@@ -18,13 +18,11 @@ class _BattOrBenchmark(perf_benchmark.PerfBenchmark):
filter_string='toplevel')
options = timeline_based_measurement.Options(category_filter)
options.config.chrome_trace_config.category_filter.AddFilterString('rail')
- # TODO(charliea): Reenable the CPU tracing agent once it no longer causes
- # indefinite hangs on Windows.
- # https://crbug.com/647443
- options.config.enable_battor_trace = True
- options.config.enable_chrome_trace = True
options.config.enable_atrace_trace = True
options.config.atrace_config.categories = ['sched']
+ options.config.enable_battor_trace = True
+ options.config.enable_chrome_trace = True
+ options.config.enable_cpu_trace = True
options.SetTimelineBasedMetrics(
['powerMetric', 'clockSyncLatencyMetric', 'cpuTimeMetric'])
return options
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698