DescriptionRevert of Split MinidumpUploadService into core- and Chrome-implementation. (patchset #5 id:80001 of https://codereview.chromium.org/2441623002/ )
Reason for revert:
Componentizing the MinidumpUploadService is a pain - and not strictly necessary - we have to set the MinidumpUploadDelegate before the service uses this delegate, but the service might be started by the system rather than by Chrome itself. See crbug.com/660075
Original issue's description:
> Split MinidumpUploadService into core- and Chrome-implementation.
>
> To componentize MinidumpUploadService we split it into its core
> implementation and an implementation dependent on Chrome. The
> Chrome-dependent parts now live in ChromeMinidumpUploadDelegate.
>
> To inject this delegate into the MinidumpUploadService we have to create
> a Chrome-specific version of the MinidumpUploadService (inheriting from
> it) named ChromeMinidumpUploadService.
>
> BUG=652719
>
> Committed: https://crrev.com/271ef66ac8bab41f55f18586a1cd2fd2970d4d79
> Cr-Commit-Position: refs/heads/master@{#427989}
TBR=isherman@chromium.org,mariakhomenko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=652719, 660075
Committed: https://crrev.com/012becd22e310a14a4cc53db562592a5622bd222
Cr-Commit-Position: refs/heads/master@{#428667}
Patch Set 1 #Messages
Total messages: 8 (4 generated)
|