Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2466443002: Revert of Split MinidumpUploadService into core- and Chrome-implementation. (Closed)

Created:
4 years, 1 month ago by gsennton
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman, Maria
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split MinidumpUploadService into core- and Chrome-implementation. (patchset #5 id:80001 of https://codereview.chromium.org/2441623002/ ) Reason for revert: Componentizing the MinidumpUploadService is a pain - and not strictly necessary - we have to set the MinidumpUploadDelegate before the service uses this delegate, but the service might be started by the system rather than by Chrome itself. See crbug.com/660075 Original issue's description: > Split MinidumpUploadService into core- and Chrome-implementation. > > To componentize MinidumpUploadService we split it into its core > implementation and an implementation dependent on Chrome. The > Chrome-dependent parts now live in ChromeMinidumpUploadDelegate. > > To inject this delegate into the MinidumpUploadService we have to create > a Chrome-specific version of the MinidumpUploadService (inheriting from > it) named ChromeMinidumpUploadService. > > BUG=652719 > > Committed: https://crrev.com/271ef66ac8bab41f55f18586a1cd2fd2970d4d79 > Cr-Commit-Position: refs/heads/master@{#427989} TBR=isherman@chromium.org,mariakhomenko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=652719, 660075 Committed: https://crrev.com/012becd22e310a14a4cc53db562592a5622bd222 Cr-Commit-Position: refs/heads/master@{#428667}

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
gsennton
Created Revert of Split MinidumpUploadService into core- and Chrome-implementation.
4 years, 1 month ago (2016-10-31 07:53:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466443002/1
4 years, 1 month ago (2016-10-31 07:54:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 08:44:49 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 08:46:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/012becd22e310a14a4cc53db562592a5622bd222
Cr-Commit-Position: refs/heads/master@{#428667}

Powered by Google App Engine
This is Rietveld 408576698